Actions
Idea #10005
closed
[Crunch2][API] Rename "workflow" attribute in a workflow object as "definition"
Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
09/09/2016
Due date:
Story points:
-
Release:
Release relationship:
Auto
Description
Any other word other than "workflow" for this attribute in the "workflow" object would be a lesser evil because it will eliminate the confusion as to whether you are talking about the object type or attribute.
Discussed on engineering channel and Peter suggested "definition" and TomM agreed.
Updated by Radhika Chippada over 7 years ago
- Description updated (diff)
- Status changed from New to In Progress
- Assigned To set to Radhika Chippada
- Target version set to 2016-09-14 sprint
Updated by Lucas Di Pentima over 7 years ago
API Server tests run OK on my end. Just a little detail on the fixture file:
-workflow_with_workflow_yml: +workflow_with_definition_yml: uuid: zzzzz-7fd4e-validworkfloyml owner_uuid: zzzzz-tpzed-xurymjxw79nv3jz name: Valid workflow with name and desc description: this workflow has a valid workflow yaml - workflow: "name: foo\ndesc: bar" + definition: "name: foo\ndesc: bar" created_at: 2016-08-15 12:00:00 -workflow_with_no_workflow_yml: +workflow_with_no_definition_yml: uuid: zzzzz-7fd4e-validbutnoyml00 owner_uuid: zzzzz-tpzed-xurymjxw79nv3jz name: Valid workflow with no workflow yaml
Maybe the name and description of those can be updated to be in tune with the new naming convention.
Apart from that, LGTM!
Updated by Radhika Chippada over 7 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:d51c716d0d547ecea25819678c6e50b647051da9.
Actions