Project

General

Profile

Actions

Story #10005

closed

[Crunch2][API] Rename "workflow" attribute in a workflow object as "definition"

Added by Radhika Chippada about 6 years ago. Updated about 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
09/09/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto

Description

Any other word other than "workflow" for this attribute in the "workflow" object would be a lesser evil because it will eliminate the confusion as to whether you are talking about the object type or attribute.

Discussed on engineering channel and Peter suggested "definition" and TomM agreed.


Subtasks 1 (0 open1 closed)

Task #10006: Review branch 10005-rename-workflow-in-workflow-as-definitionResolvedLucas Di Pentima09/09/2016

Actions
Actions #1

Updated by Radhika Chippada about 6 years ago

  • Description updated (diff)
  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version set to 2016-09-14 sprint
Actions #2

Updated by Lucas Di Pentima about 6 years ago

API Server tests run OK on my end. Just a little detail on the fixture file:

-workflow_with_workflow_yml:
+workflow_with_definition_yml:
   uuid: zzzzz-7fd4e-validworkfloyml
   owner_uuid: zzzzz-tpzed-xurymjxw79nv3jz
   name: Valid workflow with name and desc
   description: this workflow has a valid workflow yaml
-  workflow: "name: foo\ndesc: bar" 
+  definition: "name: foo\ndesc: bar" 
   created_at: 2016-08-15 12:00:00

-workflow_with_no_workflow_yml:
+workflow_with_no_definition_yml:
   uuid: zzzzz-7fd4e-validbutnoyml00
   owner_uuid: zzzzz-tpzed-xurymjxw79nv3jz
   name: Valid workflow with no workflow yaml

Maybe the name and description of those can be updated to be in tune with the new naming convention.

Apart from that, LGTM!

Actions #3

Updated by Radhika Chippada about 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:d51c716d0d547ecea25819678c6e50b647051da9.

Actions

Also available in: Atom PDF