Arvados

78fedce

Added session_client_id on workbench's lograge and also on requests to the API server.

Complete tests being run at: https://ci.curoverse.com/job/developer-test-job/197/

• I am wondering if it would be better if we move set_client_session_id filter to come before other filters such as find_object_by_uuid

• It appears that client_session_id is being sent even without the lograge update. Why do we need this?

• Please unpyramid the lines in this test
  

     test "requesting to the API server includes client_session_id param" do
  -    use_token :active do
  +    use_token :active
  

• Do we need to clear the client_session_id in thread_clear?

• Nit: As a general practice, I prefer to add new stuff at the bottom of the file, or at an appropriate place to help preserve the flow of the file readability.

Radhika Chippada wrote:

• I am wondering if it would be better if we move set_client_session_id filter to come before other filters such as find_object_by_uuid

Changed as a prepend_before_filter as Tom requested.

• It appears that client_session_id is being sent even without the lograge update. Why do we need this?

Yes, but the log line indicating the currect workbench request didn't include the request_id

• Please unpyramid the lines in this test

Done

• Do we need to clear the client_session_id in thread_clear?

Cleared after lograge uses it, thanks to Tom for that idea!

• Nit: As a general practice, I prefer to add new stuff at the bottom of the file, or at an appropriate place to help preserve the flow of the file readability.

Updated!

Updates at: ff71d32

LGTM