Project

General

Profile

Actions
Copy link

Bug #10037

closed

[Crunch2/Workbench] Non-running container requests show a useless progress bar on dashboard

Added by Peter Amstutz over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Lucas Di Pentima
Category:
-
Target version:
2016-09-28 sprint
Story points:
0.5
Release:
Crunch v2
Release relationship:
Auto

Files

dashboard.png (40.7 KB) dashboard.png Radhika Chippada, 09/22/2016 01:57 AM

Subtasks 1 (0 open — 1 closed)

Task #10057: Review 10037-useless-progress-barResolvedLucas Di Pentima09/22/2016Actions
Actions
Copy link
 #1

Updated by Peter Amstutz over 7 years ago

  • Subject changed from [Crunch2] Non-running container requests show a useless progress bar on dashboard to [Crunch2/Workbench] Non-running container requests show a useless progress bar on dashboard
Actions
Copy link
 #2

Updated by Tom Morris over 7 years ago

  • Target version set to 2016-09-28 sprint
  • Story points set to 0.5
Actions
Copy link
 #3

Updated by Lucas Di Pentima over 7 years ago

  • Assigned To set to Lucas Di Pentima
Actions
Copy link
 #4

Updated by Lucas Di Pentima over 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #5

Updated by Lucas Di Pentima over 7 years ago

69963d8

A very simple change, test is missing.

Actions
Copy link
 #6

Updated by Lucas Di Pentima over 7 years ago

2e319c5e3ebd1bf61f74b01646b755fffccb984c

Ready for review.
Added tests and fixed an integration test broken because of some modifications made on the container request fixture.

Full tests being run on: https://ci.curoverse.com/job/developer-test-job/201/

Actions
Copy link
 #7

Updated by Radhika Chippada over 7 years ago

  • It would be desirable that the status label for “Not started” is aligned with “Complete”. Would you please use the 12 column spacing with 6 for link and 6 with 2 for label and 4 unused? It looked better that way when I tried. Please see attachment dashboard.png.
  • In the test “in dashboard the progress bar should only show on running containers”
    • Would you please expand this test to also look for the status of the non-running objects also? Currently, it is using a “should_show”. Instead you can use something like “shows progress bar” or “shows complete label” or “shows not running label” etc. That way, you can check for all the objects’ statuses in this test.
    • Would you also please include a few pipeline instances in this test, not just container requests?
    • You might want to call this test something like “check status in dashboard …”
Actions
Copy link
 #8

Updated by Lucas Di Pentima over 7 years ago

  • Styling fixes done
  • Test improved to check for other state labels on CRs and Pipeline Instances, as requested!

8db021c

Actions
Copy link
 #9

Updated by Radhika Chippada over 7 years ago

  • The test "dashboard should show the correct status for containers and processes" is impressive. Thanks.
  • Nit: We are using "pipelines and processes" to mean "pipelines and other types". So "containers and processes" is next level :). You can just call it "dashboard should show the correct status for containers and processes"

LGTM

Actions
Copy link
 #10

Updated by Lucas Di Pentima over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:fe8f132725aea9816447ac8a9804b7942bc5dffd.

Actions
Copy link

Also available in: Atom PDF