Bug #10110
closed
arv-copy to support Workflow
Description
Usage:
$ arv-copy --src source_cluster --dst dest_cluster 962eh-7fd4e-660fw86nz0w77mk
- Copy "name", "description" and "definition" fields.
- Load the contents of the "definiton" field as YAML. Recursively search the YAML for "location" fields, for example
location: 'keep:2463fa9efeb75e099685528b3b9071e0+438/19.fasta.bwt'
Parse thekeep:URI to get the PDH the collection and add it to a set. - Go through the set and use existing arv-copy functionality to copy the collections referenced in the definition.
Updated by Tom Morris over 8 years ago
- Target version set to Arvados Future Sprints
- Story points set to 2.0
Manually tested. Update documentation as well.
Updated by Radhika Chippada about 8 years ago
- Assigned To set to Radhika Chippada
- Target version changed from Arvados Future Sprints to 2017-01-18 sprint
Updated by Peter Amstutz about 8 years ago
- Description updated (diff)
- Target version changed from 2017-01-18 sprint to Arvados Future Sprints
Updated by Peter Amstutz about 8 years ago
- Target version changed from Arvados Future Sprints to 2017-01-18 sprint
Updated by Radhika Chippada about 8 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 8 years ago
Some comments:
sdk/python/arvados/commands/arv_copy.pyfile:- Line 116: Command’s description could be updated to reflect the new feature
- Lines 412-422: Should that documentation be as a docstring inside the func?
- Line 438: Should
wf_defbe passed instead ofgraph? - Lines 458-460: To improve readability, do you think it would be better to replace those 3 lines with a single assignment like:
var = one() or another()? - Line 468: I believe that
ifcan be replaced withelif
- As you mentioned, I too think that ruamel.yaml should be added as a dependency. It seems that Python doesn’t have ALL the batteries included after all.
- Do you think a test for this feature would be desirable?
Updated by Radhika Chippada about 8 years ago
Line 116: Command’s description could be updated to reflect the new feature
You are right. Updated.
Lines 412-422: Should that documentation be as a docstring inside the func?
The documentation for recursive, project_uuid etc already exists. This comment is additional code comment only, aimed at code maintenance.
Line 438: Should wf_def be passed instead of graph?
Thanks for catching this. Corrected.
Lines 458-460: To improve readability, do you think it would be better to replace those 3 lines with a single assignment like: var = one() or another() ?
Updated and thanks for teaching :)
Line 468: I believe that if can be replaced with elif
Corrected
As you mentioned, I too think that ruamel.yaml should be added as a dependency. It seems that Python doesn’t have ALL the batteries included after all.
Added ruamel.yaml to setup.py per Peter's suggestion
Do you think a test for this feature would be desirable?
Unfortunately, this feature has no automated tests yet and Peter agreed that I only manually test for now.
Thanks.
Updated by Radhika Chippada about 8 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:565e1cc82ed0af5a4d58ea78d6e0294afdd1cba8.