Story #10112

[Crunch2][Workbench]workflow#show page (similar to pipeline_template#show page)

Added by Radhika Chippada almost 5 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
05/09/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release:
Release relationship:
Auto

Description

Include editable name and description field.
Also should include a "Run this workflow" button.

workflow.jpg (61.4 KB) workflow.jpg Radhika Chippada, 05/09/2017 03:03 PM

Subtasks

Task #11472: Review 10112-workflow-showResolvedRadhika Chippada

Associated revisions

Revision a5c53dce
Added by Radhika Chippada over 4 years ago

closes #10112
Merge branch '10112-workflow-show'

History

#1 Updated by Peter Amstutz over 4 years ago

  • Description updated (diff)

#2 Updated by Tom Morris over 4 years ago

  • Target version set to 2017-04-26 sprint

#3 Updated by Tom Morris over 4 years ago

  • Description updated (diff)
  • Story points set to 1.0

#4 Updated by Lucas Di Pentima over 4 years ago

  • Assigned To set to Lucas Di Pentima

#5 Updated by Radhika Chippada over 4 years ago

  • Status changed from New to In Progress
  • Assigned To changed from Lucas Di Pentima to Radhika Chippada

#6 Updated by Radhika Chippada over 4 years ago

  • Target version changed from 2017-04-26 sprint to 2017-05-10 sprint

#7 Updated by Bryan Cosca over 4 years ago

Showing these would be helpful:

baseCommand: [bwa, mem]
arguments: - {prefix: -t, valueFrom: $(runtime.cores)} - {prefix: -R, valueFrom: "@RG\tID:$(inputs.group_id)\tPL:$(inputs.PL)\tSM:$(inputs.sample_id)"}

(baseCommand before arguments)

hints: - {class: DockerRequirement, dockerImageId: biodckr/bwa, dockerPull: biodckr/bwa}

The DockerImageId should link to the collection of the docker image.

inputs:

outputs: if possible

#8 Updated by Radhika Chippada over 4 years ago

#9 Updated by Radhika Chippada over 4 years ago

Branch 10112-workflow-show @ 4c1d34e

Using the partial show_text_with_locators (from #10645), displays baseCommand, arguments, hints, inputs, outputs in workflow Definition tab.

Test run @ https://ci.curoverse.com/job/developer-run-tests/281/

#10 Updated by Lucas Di Pentima over 4 years ago

A couple comments:

  • DockerImageId is not being rendered as a collection link as suggested on note-7, is this possible?
  • Will the workflow definition have additional data that we would like to show? Maybe we can have a generic way of showing the YAML so that the partial doesn’t need to be updated when using a wf_def with new fields?

#11 Updated by Radhika Chippada over 4 years ago

DockerImageId is not being rendered as a collection link as suggested on note-7, is this possible?

Peter said it is quite involved and for now we just display the text

Will the workflow definition have additional data that we would like to show? Maybe we can have a generic way of showing the YAML so that the partial doesn’t need to be updated when using a wf_def with new fields?

For now this would do as Bryan suggested. Other fields may or may not fit the same display strategy (for example, uuids etc).

#12 Updated by Lucas Di Pentima over 4 years ago

Great, this LGTM.

#13 Updated by Radhika Chippada over 4 years ago

Preload collections @ a7bd5fa

#14 Updated by Radhika Chippada over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:a5c53dceed8480e667249fc5fee3349bbaf20ec8.

Also available in: Atom PDF