https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-09-23T18:42:01ZArvadosArvados - Bug #10124: [FUSE] Fix flaky test FuseUpdateFromEventTesthttps://dev.arvados.org/issues/10124?journal_id=434132016-09-23T18:42:01ZRadhika Chippadaradhika@curoverse.com
<ul></ul><p>Review comments:</p>
<ul>
<li>AssertWithin might be clearer if AssertWithinInterval? Also, instead of “seconds” can you please call it “interval”?</li>
</ul>
<ul>
<li>In AssertWithin -> attempt, can you add a "time expired" message to "raise" when "time.time() > self.deadline"?</li>
</ul>
<ul>
<li>Am I understanding it correctly (sorry, python) that if AssertWithin -> attempt, if the “fn” fails for any other errors, they will be raised and the test will fail as needed?</li>
</ul> Arvados - Bug #10124: [FUSE] Fix flaky test FuseUpdateFromEventTesthttps://dev.arvados.org/issues/10124?journal_id=434162016-09-23T18:58:31ZTom Cleggtom@curii.com
<ul></ul><p>Radhika Chippada wrote:</p>
<blockquote>
<ul>
<li>AssertWithin might be clearer if AssertWithinInterval? Also, instead of “seconds” can you please call it “interval”?</li>
</ul>
</blockquote>
<p>Changed to AssertWithTimeout(timeout=x) -- timeout seems to be the customary Python word for this.</p>
<blockquote>
<ul>
<li>In AssertWithin -> attempt, can you add a "time expired" message to "raise" when "time.time() > self.deadline"?</li>
</ul>
</blockquote>
<p>"raise" by itself raises the original assertion error with test's own message, which seems more useful. For example, changing the timeout from 10 to 0.00001 results in</p>
<pre>
runTest (tests.test_mount.FuseUpdateFromEventTest) ... FAIL
======================================================================
FAIL: runTest (tests.test_mount.FuseUpdateFromEventTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tom/src/arvados/services/fuse/tests/test_mount.py", line 744, in runTest
attempt(self.assertEqual, ["file1.txt"], llfuse.listdir(os.path.join(self.mounttmp)))
File "/home/tom/src/arvados/services/fuse/tests/test_mount.py", line 44, in attempt
fn(*args, **kwargs)
AssertionError: Lists differ: ['file1.txt'] != []
First list contains 1 additional elements.
First extra element 0:
file1.txt
- ['file1.txt']
+ []
</pre>
<blockquote>
<ul>
<li>Am I understanding it correctly (sorry, python) that if AssertWithin -> attempt, if the “fn” fails for any other errors, they will be raised and the test will fail as needed?</li>
</ul>
</blockquote>
<p>Yes, that's right.</p> Arvados - Bug #10124: [FUSE] Fix flaky test FuseUpdateFromEventTesthttps://dev.arvados.org/issues/10124?journal_id=434182016-09-23T19:15:35ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Bug #10124: [FUSE] Fix flaky test FuseUpdateFromEventTesthttps://dev.arvados.org/issues/10124?journal_id=434222016-09-24T02:55:05ZTom Cleggtom@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:c2fdf5d225efe65edcab383b213eca27e2cca30e.</p>