Project

General

Profile

Actions

Feature #10223

closed

[Crunch2] Add ability to set name of output collection

Added by Tom Morris over 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
01/04/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5
Release:
Release relationship:
Auto

Description

Add output_name column to container_requests table.

Use that name (if given) when copying to final output. If there is a name conflict, append the current timestamp in ISO8601 with 1-second precision.

cwlrunner to set output name when creating container request


Subtasks 2 (0 open2 closed)

Task #10748: Review 10223-cr-set-output-nameResolvedLucas Di Pentima01/04/2017

Actions
Task #10829: Add output_name to full text search, with relevant test.ResolvedLucas Di Pentima01/05/2017

Actions
Actions #1

Updated by Tom Morris over 7 years ago

  • Story points set to 0.5
Actions #2

Updated by Tom Morris over 7 years ago

  • Description updated (diff)
  • Assigned To set to Radhika Chippada
Actions #3

Updated by Tom Clegg over 7 years ago

  • Description updated (diff)
Actions #4

Updated by Tom Morris over 7 years ago

  • Project changed from 35 to Arvados
Actions #5

Updated by Tom Clegg over 7 years ago

  • Description updated (diff)
Actions #6

Updated by Tom Morris about 7 years ago

  • Target version set to 2017-01-04 sprint
Actions #7

Updated by Tom Clegg about 7 years ago

  • Assigned To changed from Radhika Chippada to Tom Clegg
Actions #8

Updated by Lucas Di Pentima about 7 years ago

  • Status changed from New to In Progress
  • Assigned To changed from Tom Clegg to Lucas Di Pentima
Actions #9

Updated by Lucas Di Pentima about 7 years ago

Branch 10223-cr-set-output-name: 6599088
Test run: https://ci.curoverse.com/job/developer-run-tests/126/

Actions #10

Updated by Radhika Chippada about 7 years ago

@ 6599088b

  • Can you please break the new test into two tests: (1) using some output name that is acceptable, (2) an output_name such as "foo_file" that is already existing on a collection fixture owned by the 'active' user? Alternatively, you can just use (2) since it will cover case (1) also.
  • Does the updated test eliminate the need for this? ActiveRecord::Base.connection.execute 'ROLLBACK'
  • I noticed that we unfortunately do not have a test such as "full text search indexes are up to date" similar to "search index exists on models that go into projects" which is resulting in the fts index being out of sync with the code updates. Please add a subtask to update the fts index as well (and add that new test). Thanks.
Actions #11

Updated by Lucas Di Pentima about 7 years ago

  • Target version changed from 2017-01-04 sprint to 2017-01-18 sprint
Actions #12

Updated by Lucas Di Pentima about 7 years ago

Radhika Chippada wrote:

  • Can you please break the new test into two tests: (1) using some output name that is acceptable, (2) an output_name such as "foo_file" that is already existing on a collection fixture owned by the 'active' user? Alternatively, you can just use (2) since it will cover case (1) also.

Done.

  • Does the updated test eliminate the need for this? ActiveRecord::Base.connection.execute 'ROLLBACK'

No, because every unit test in run inside a transaction. I added a comment explaining why that execution is there.

  • I noticed that we unfortunately do not have a test such as "full text search indexes are up to date" similar to "search index exists on models that go into projects" which is resulting in the fts index being out of sync with the code updates. Please add a subtask to update the fts index as well (and add that new test). Thanks.

Also, done.

Updates: c9199d2
Test run: https://ci.curoverse.com/job/developer-run-tests/130/

Actions #13

Updated by Radhika Chippada about 7 years ago

Lucas: thank you very much for adding the missing unit test for full text search indexes. LGTM

Actions #14

Updated by Lucas Di Pentima about 7 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:7eda5880411d1146c08f3e4a507fa24d5590d5dc.

Actions

Also available in: Atom PDF