Feature #10223
closed
[Crunch2] Add ability to set name of output collection
Added by Tom Morris over 7 years ago.
Updated over 7 years ago.
Release relationship:
Auto
Description
Add output_name column to container_requests table.
Use that name (if given) when copying to final output. If there is a name conflict, append the current timestamp in ISO8601 with 1-second precision.
cwlrunner to set output name when creating container request
- Description updated (diff)
- Assigned To set to Radhika Chippada
- Description updated (diff)
- Project changed from 35 to Arvados
- Description updated (diff)
- Target version set to 2017-01-04 sprint
- Assigned To changed from Radhika Chippada to Tom Clegg
- Status changed from New to In Progress
- Assigned To changed from Tom Clegg to Lucas Di Pentima
@ 6599088b
- Can you please break the new test into two tests: (1) using some output name that is acceptable, (2) an output_name such as "foo_file" that is already existing on a collection fixture owned by the 'active' user? Alternatively, you can just use (2) since it will cover case (1) also.
- Does the updated test eliminate the need for this? ActiveRecord::Base.connection.execute 'ROLLBACK'
- I noticed that we unfortunately do not have a test such as "full text search indexes are up to date" similar to "search index exists on models that go into projects" which is resulting in the fts index being out of sync with the code updates. Please add a subtask to update the fts index as well (and add that new test). Thanks.
- Target version changed from 2017-01-04 sprint to 2017-01-18 sprint
Radhika Chippada wrote:
- Can you please break the new test into two tests: (1) using some output name that is acceptable, (2) an output_name such as "foo_file" that is already existing on a collection fixture owned by the 'active' user? Alternatively, you can just use (2) since it will cover case (1) also.
Done.
- Does the updated test eliminate the need for this? ActiveRecord::Base.connection.execute 'ROLLBACK'
No, because every unit test in run inside a transaction. I added a comment explaining why that execution is there.
- I noticed that we unfortunately do not have a test such as "full text search indexes are up to date" similar to "search index exists on models that go into projects" which is resulting in the fts index being out of sync with the code updates. Please add a subtask to update the fts index as well (and add that new test). Thanks.
Also, done.
Updates: c9199d2
Test run: https://ci.curoverse.com/job/developer-run-tests/130/
Lucas: thank you very much for adding the missing unit test for full text search indexes. LGTM
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:7eda5880411d1146c08f3e4a507fa24d5590d5dc.
Also available in: Atom
PDF
Updated by Tom Morris 
Updated by 
Updated by 
Updated by Radhika Chippada