Arvados

Tests are failing:

IOError: [Errno 2] No such file or directory: 'tests/discovery-f850a12e2daa64bc0c800e6d680f8e07.json'

I'm guessing this is a file that didn't get git-added.

But before you add it, why not get the real discovery doc, and modify it as needed? Including a [modified] snapshot of a real discovery doc from some point in history (I'm just guessing that's what's in the missing file) seems like an unnecessary maintenance headache.

Suggest renaming _rootDesc.py to something a little more normal/explanatory like mock_discovery.py.

The actual enable_reuse / use_existing changes LGTM.

Tom Clegg wrote:

Tests are failing:

[...]

I'm guessing this is a file that didn't get git-added.

You're right. Fixed.

But before you add it, why not get the real discovery doc, and modify it as needed?

Including a [modified] snapshot of a real discovery doc from some point in history (I'm just guessing that's what's in the missing file) seems like an unnecessary maintenance headache.

It is a real (unmodified) discovery doc, which is modified on the fly for the one test that needs it. Since all tests are supposed to use mocks instead of relying on a live API server, I don't want to require having an API server running for no other purpose than to serve a discovery doc.

Suggest renaming _rootDesc.py to something a little more normal/explanatory like mock_discovery.py.

Done.

The actual enable_reuse / use_existing changes LGTM.

I added a couple more tests to assert that the flag is correctly propagated through.

Now at 661cc25829ee78ef42dc4602648ae015a93c12e7

Please back out the discovery document snapshot.

Let's fix the bug for now, and leave the test infrastructure as it was until we come up with a better solution.

Fixed in package python-arvados-cwl-runner 1.0.20161103172804-3