Bug #10519

[Workbench] fiddlesticks viewing container request 9tee4-xvhdp-q4bgh7mxr0bikop

Added by Ward Vandewege almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
12/05/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

This is an old container request. Maybe there are required fields missing. But workbench shouldn't error out.


Subtasks

Task #10661: Review 10519-cr-fiddlesticksResolvedPeter Amstutz

Associated revisions

Revision 0936c2e7
Added by Peter Amstutz almost 5 years ago

Merge branch '10519-cr-fiddlesticks' closes 9tee4-xvhdp-q4bgh7mxr0bikop (Resolved)" href="/issues/10519">#10519

History

#1 Updated by Ward Vandewege almost 5 years ago

  • Description updated (diff)

#2 Updated by Ward Vandewege almost 5 years ago

  • Project changed from OPS to Arvados

#3 Updated by Tom Clegg almost 5 years ago

undefined method `[]' for nil:NilClass

#4 Updated by Lucas Di Pentima almost 5 years ago

The error message on Workbench's log is:

...
#<NoMethodError: undefined method `[]' for nil:NilClass>
/Users/lucas/Devel/git/arvados/apps/workbench/app/views/container_requests/_show_inputs.html.erb:1:in `_app_views_container_requests__show_inputs_html_erb___3727096099106662238_70295093222720'
/Users/lucas/.rvm/gems/ruby-2.2.1@workbench/gems/actionview-4.1.12/lib/action_view/template.rb:145:in `block in render'
...

source:apps/workbench/app/views/container_requests/_show_inputs.html.erb#L1

<% n_inputs = cwl_inputs_required(@object, get_cwl_inputs(@object.mounts[:"/var/lib/cwl/workflow.json"][:content]), [:mounts, :"/var/lib/cwl/cwl.input.json", :content]) %>

#5 Updated by Tom Clegg almost 5 years ago

  • Story points set to 0.5

#6 Updated by Peter Amstutz almost 5 years ago

  • Status changed from New to In Progress
  • Assigned To set to Peter Amstutz
  • Target version changed from Arvados Future Sprints to 2016-12-14 sprint

Branch 10519-cr-fiddlesticks

#7 Updated by Radhika Chippada almost 5 years ago

Code update LGTM. I also added an integration test.

#8 Updated by Peter Amstutz almost 5 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:0936c2e7630c0e4316684c5b79965ad7dfaf9fa4.

Also available in: Atom PDF