Story #10524

[Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.

Added by Radhika Chippada almost 5 years ago. Updated almost 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
11/21/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release:
Release relationship:
Auto

Description

Refers to #10310


Subtasks

Task #10578: Review branch 10524-crunch2-workbenchResolvedRadhika Chippada

Associated revisions

Revision 6f461f4d
Added by Radhika Chippada almost 5 years ago

closes #10524
Merge branch '10524-crunch2-workbench'

Revision adda9397
Added by Radhika Chippada almost 5 years ago

refs #10524
Merge branch '10524-crunch2-workbench'

History

#1 Updated by Radhika Chippada almost 5 years ago

  • Subject changed from [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment. Refers to #10310 to [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.
  • Description updated (diff)

#2 Updated by Tom Morris almost 5 years ago

  • Assigned To set to Radhika Chippada
  • Target version set to 2016-11-23 sprint

#3 Updated by Radhika Chippada almost 5 years ago

  • Status changed from New to In Progress

#4 Updated by Radhika Chippada almost 5 years ago

Branch 10524-crunch2-workbench is ready at 185bc33b

Test runs @ https://ci.curoverse.com/job/developer-run-tests/75/

#5 Updated by Lucas Di Pentima almost 5 years ago

  • I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment". The no_jobs_api var isn't used anywhere else in the templates, so it can be avoided.
  • Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Jenkins tests seem to have had some kind of problem. I ran apps/workbench tests locally without failures.

#6 Updated by Radhika Chippada almost 5 years ago

I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment".

Updated

Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Updated controller disabled api test

Thanks.

#7 Updated by Radhika Chippada almost 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:6f461f4d0a996da85140982846a5d5c10ccfaae4.

#8 Updated by Tom Clegg over 2 years ago

  • Related to Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active added

#9 Updated by Tom Clegg over 2 years ago

  • Related to deleted (Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active)

Also available in: Atom PDF