Project

General

Profile

Actions

Idea #10524

closed

[Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.

Added by Radhika Chippada over 7 years ago. Updated over 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Story points:
-
Release:
Release relationship:
Auto

Description

Refers to #10310


Subtasks 1 (0 open1 closed)

Task #10578: Review branch 10524-crunch2-workbenchResolvedRadhika Chippada11/21/2016Actions
Actions #1

Updated by Radhika Chippada over 7 years ago

  • Subject changed from [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment. Refers to #10310 to [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.
  • Description updated (diff)
Actions #2

Updated by Tom Morris over 7 years ago

  • Assigned To set to Radhika Chippada
  • Target version set to 2016-11-23 sprint
Actions #3

Updated by Radhika Chippada over 7 years ago

  • Status changed from New to In Progress
Actions #4

Updated by Radhika Chippada over 7 years ago

Branch 10524-crunch2-workbench is ready at 185bc33b

Test runs @ https://ci.curoverse.com/job/developer-run-tests/75/

Actions #5

Updated by Lucas Di Pentima over 7 years ago

  • I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment". The no_jobs_api var isn't used anywhere else in the templates, so it can be avoided.
  • Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Jenkins tests seem to have had some kind of problem. I ran apps/workbench tests locally without failures.

Actions #6

Updated by Radhika Chippada over 7 years ago

I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment".

Updated

Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Updated controller disabled api test

Thanks.

Actions #7

Updated by Radhika Chippada over 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:6f461f4d0a996da85140982846a5d5c10ccfaae4.

Actions #8

Updated by Tom Clegg about 5 years ago

  • Related to Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active added
Actions #9

Updated by Tom Clegg about 5 years ago

  • Related to deleted (Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active)
Actions

Also available in: Atom PDF