Idea #10524: [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment. - Arvados

Custom queries

All assigned issues
All issues assigned for grooming
My issues for grooming
My issues for grooming (no story pts)
Prioritized open issues

Actions

Copy link

Idea #10524

closed

[Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.

Added by Radhika Chippada over 7 years ago. Updated over 7 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Radhika Chippada

Category:

Target version:

2016-11-23 sprint

Story points:

Release:

Crunch v2

Release relationship:

Auto

Description

Refers to #10310

Subtasks 1 (0 open — 1 closed)

Task #10578: Review branch 10524-crunch2-workbench

Resolved

Radhika Chippada

11/21/2016

Actions

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Radhika Chippada over 7 years ago

Subject changed from [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment. Refers to #10310 to [Crunch2] In Crunch2-only environments, workbench should use "processes" instead of "pipelines and processes" and "workflows" instead of "pipeline templates" as is used in a mixed environment.
Description updated (diff)

Actions

Copy link

Updated by Tom Morris over 7 years ago

Assigned To set to Radhika Chippada
Target version set to 2016-11-23 sprint

Actions

Copy link

Updated by Radhika Chippada over 7 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Radhika Chippada over 7 years ago

Branch 10524-crunch2-workbench is ready at 185bc33b

Test runs @ https://ci.curoverse.com/job/developer-run-tests/75/

Actions

Copy link

Updated by Lucas Di Pentima over 7 years ago

I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment". The no_jobs_api var isn't used anywhere else in the templates, so it can be avoided.
Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Jenkins tests seem to have had some kind of problem. I ran apps/workbench tests locally without failures.

Actions

Copy link

Updated by Radhika Chippada over 7 years ago

I think it would be clearer if the labels are assigned inside a single conditional, avoiding the "double assignment".

Updated

Do you think writing some tests to check those alternating labels would be useful? Maybe mocking PipelineInstance.api_exist? would allow an easy way of testing the changes.

Updated controller disabled api test

Thanks.

Actions

Copy link