Bug #10587
closedAll Python CLI utilities should report --version
Related issues
Updated by Tom Morris almost 8 years ago
- Subject changed from All CLI utilities should report --version to All Python CLI utilities should report --version
- Assigned To set to Lucas Di Pentima
- Story points set to 1.0
Updated by Lucas Di Pentima almost 8 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima almost 8 years ago
Test run at: https://ci.curoverse.com/job/developer-run-tests/87/
Updates: fee8873
Added --version to the following commands:
- arv-ls
- arv-put
- arv-ws
- arv-get
- arv-copy
- arv-run
- arv-normalize
- arv-keepdocker
- arv-mount
- arvados-node-manager
Also added tests to confirm the new argument.
Updated by Tom Clegg almost 8 years ago
Looks like we need to add setuptools dependency to our deb/rpm packages, like we did for arvados-cwl-runner, in order to use this mechanism.
I guess it also makes sense to add setuptools to install_requires in setup.py.
Tried in wheezy, and found that the wheezy version of python-setuptools (0.6.24-1) does work, so at least we don't have to build another new package.
I'm very wary of using multiprocessing in tests, especially arv-put which definitely uses threading. Combining multiprocessing and threading in Python seems to be a recipe for disaster (or at least unbounded debugging efforts). Can we get what we need just by catching SystemExit? In source:services/fuse/tests/test_command_args.py it looks like this works for argparse. Failing that, maybe subprocess?
Updated by Lucas Di Pentima almost 8 years ago
Updates at: ceae525
Test suite run at: https://ci.curoverse.com/job/developer-run-tests/88/
- Changed those tests depending on multiprocessing to use a context manager stderr/stdout redirector and a SystemExit catching assertion as requested.
- Added setuptools dependencies on package building script and setup.py install_require definitions.
Updated by Lucas Di Pentima almost 8 years ago
Merged master into branch at feb463839301b0b596089e48a981660365d2c4a7
Tests running: https://ci.curoverse.com/job/developer-run-tests/89/
Updated by Lucas Di Pentima almost 8 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:0514b290f5ff9a2700b599bf6fb19a468a73c3fb.