https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-12-05T19:57:12ZArvadosArvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=460182016-12-05T19:57:12ZTom Cleggtom@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/46018/diff?detail_id=44266">diff</a>)</li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=545812017-08-29T14:28:21ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> set to <i>Arvados Future Sprints</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=561462017-10-19T21:32:07ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Subject</strong> changed from <i>Packaged go binaries should report their own version numbers</i> to <i>All Arvados components should report their version</i></li></ul><p>This isn't specific to Go programs. I thought we'd already decided that all programs should return their version numbers (although I think we said --version, not -version).</p>
<p>Besides crunch-dispatch-slurm, what other components are we missing?</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=561472017-10-19T21:32:18ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Target version</strong> changed from <i>Arvados Future Sprints</i> to <i>2017-11-08 Sprint</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=561482017-10-19T21:35:29ZNico César
<ul></ul><p>+1</p>
<p>is hard to tell from <strong>the logs</strong> if deploys are using the correct version</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=562962017-10-25T19:27:11ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Assigned To</strong> set to <i>Tom Clegg</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=567822017-11-08T20:03:19ZTom Cleggtom@curii.com
<ul><li><strong>Assigned To</strong> deleted (<del><i>Tom Clegg</i></del>)</li><li><strong>Target version</strong> changed from <i>2017-11-08 Sprint</i> to <i>2017-11-22 Sprint</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=568012017-11-08T20:30:22ZTom Morristfmorris@veritasgenetics.com
<ul><li><strong>Assigned To</strong> set to <i>Lucas Di Pentima</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=569942017-11-20T17:56:22ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=570822017-11-22T19:19:25ZLucas Di Pentimalucas.dipentima@curii.com
<ul><li><strong>Target version</strong> changed from <i>2017-11-22 Sprint</i> to <i>2017-12-06 Sprint</i></li></ul> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=575072017-11-29T17:07:44ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>For crunch-run, can we please also log the version number either to either the "crunch-run" (cr.CrunchLog) or "node-info" (LogNodeInfo()) logger?</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=576552017-11-30T16:33:35ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Added Crunch-run version to container logs. Added test for version package. Arvados-DCO-1..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/7209d0ade292bebbc8d92f8200778b3250e4130a">7209d0ade</a> - branch <code>10666-report-version</code><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/520/">https://ci.curoverse.com/job/developer-run-tests/520/</a></p>
<p>Added a version package to Go SDK holding a variable that can be assigned the version number from the linker flags (taken from <a class="external" href="https://medium.com/@joshroppo/setting-go-1-5-variables-at-compile-time-for-versioning-5b30a965d33e">https://medium.com/@joshroppo/setting-go-1-5-variables-at-compile-time-for-versioning-5b30a965d33e</a>)</p>
<p>Added a <code>--version</code> param and version logging to the following go programs:</p>
<ul>
<li>Tools
<ul>
<li>arv-sync-groups</li>
<li>keep-block-check</li>
<li>keep-exercise</li>
<li>keep-rsync</li>
</ul>
</li>
<li>Services
<ul>
<li>arv-git-httpd</li>
<li>crunch-dispatch-local</li>
<li>crunch-dispatch-slurm</li>
<li>arvados-health</li>
<li>keep-balance</li>
<li>crunchstat</li>
<li>crunch-run</li>
<li>keep-web</li>
<li>keepproxy</li>
<li>keepstore</li>
<li>arvados-ws</li>
</ul></li>
</ul>
<p>There are some services that should also be reporting their version on their <code>/status.json</code> endpoint (pending)</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=576682017-11-30T17:51:49ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Added Version information to status.json on keep-web, keepstore & ws. Added tests. Arvado..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/60a60a176c77488cfacc7fd02e03b7b8c69de587">60a60a176</a><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/521/">https://ci.curoverse.com/job/developer-run-tests/521/</a></p>
Added version information to <code>/status.json</code> endpoint on the following services:
<ul>
<li>keepstore</li>
<li>keep-web</li>
<li>ws</li>
</ul>
<p>Also added corresponding tests.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=577012017-11-30T19:18:46ZTom Cleggtom@curii.com
<ul></ul><p>Isn't the version package superfluous? Seems like adding</p>
<pre><code>var version = "dev"</code></pre>
<p>to each program would achieve the same thing with less code...?</p>
<p>I suppose package_go_binary() in <a class="source" href="https://dev.arvados.org/projects/arvados/repository/arvados/entry/build/run-library.sh">source:build/run-library.sh</a> needs to learn how to pass the appropriate flags to go get, in order for this to be effective? Something like</p>
<pre><code>go get -ldflags "-X main.version=${version}" "git.curoverse.com/arvados.git/$src_path"</code></pre> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=577192017-11-30T19:32:24ZTom Cleggtom@curii.com
<ul></ul><pre>
$ cat <<EOF >main.go
package main
import "fmt"
var version="foo"
func main(){
fmt.Println(version)
}
EOF
$ go run main.go
foo
$ go run -ldflags "-X main.version=bar" main.go
bar
</pre> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=577642017-11-30T20:52:14ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Replaced 'version' package with 'version' var on every go program. Arvados-DCO-1.1-Signed..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/92656b214ed120c631bc6adab3b35992939e2ced">92656b214</a><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/523/">https://ci.curoverse.com/job/developer-run-tests/523/</a></p>
<p>Removed the <code>version</code> package, replaced it with <code>version</code> var on every program.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=577862017-12-01T00:15:37ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Added version information to arv-mount & nodemanager startup logging. Arvados-DCO-1.1-Sig..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/c24ca3f718f8d97103ef178546df4431ffaa2572">c24ca3f71</a><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/524/">https://ci.curoverse.com/job/developer-run-tests/524/</a></p>
<p>Add version information to arv-mount startup logging, and nodemanager logging & <code>/status.json</code> endpoint.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=577952017-12-01T15:00:40ZTom Cleggtom@curii.com
<ul></ul><p>Suggest %s rather than %q when logging version numbers at startup (hopefully we won't have version numbers that need quoting, right?)</p>
<p>"arvados health %q started" → "arvados-health %s started"</p>
<p>Should probably change the "--version" output from "Version: 1.2.3" → "arvados-health 1.2.3".</p>
<p>In arvados-ws the existing "started" log is now superfluous and should be removed.</p>
<pre>
log.Printf("arvados-ws %q started", version)
log.Info("started")
</pre>
<p>When you're in func main(), os.Exit(0) can also be written as "return", which might be a better habit since it runs any deferred statements on the way out.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=578662017-12-04T17:52:38ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Updated build script to pass the version number to go programs. Arvados-DCO-1.1-Signed-of..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/0c3b77f80068f8f5924c9f94e64a48edcbce47c7">0c3b77f800</a><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/526/">https://ci.curoverse.com/job/developer-run-tests/526/</a></p>
<p>Addressed comments from note-18, and also updated the build script to pass the version as linker flags on go programs.<br />Started to work on passing the version info to api & workbench but realized both already have that feature.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=578862017-12-04T19:43:02ZTom Cleggtom@curii.com
<ul></ul><p>Looks like the bits in "tools" dir didn't get updated from "Version: X" to "progname: X": arv-sync-groups, keep-block-check, etc.</p>
<p>with that, LGTM</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=578882017-12-04T19:55:52ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>Updates at <a class="changeset" title="10666: Merge branch 'master' into 10666-report-version Arvados-DCO-1.1-Signed-off-by: Lucas Di P..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/0c888bcc93b559339c8abbce784bdcc44746bca2">0c888bcc93b559339c8abbce784bdcc44746bca2</a><br />Test run: <a class="external" href="https://ci.curoverse.com/job/developer-run-tests/528/">https://ci.curoverse.com/job/developer-run-tests/528/</a></p>
<p>Fixed missing tools && merged master. Will merge after a successful test run.</p> Arvados - Feature #10666: All Arvados components should report their versionhttps://dev.arvados.org/issues/10666?journal_id=579162017-12-04T21:05:18ZAnonymous
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset <a class="changeset" title="Merge branch '10666-report-version' Closes #10666 Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentim..." href="https://dev.arvados.org/projects/arvados/repository/arvados/revisions/d7db1f0877015228835fac67d4ad08789d39c520">arvados|d7db1f0877015228835fac67d4ad08789d39c520</a>.</p>