Bug #10671
closed
[API Server] Fill in finish time when pipeline instance is marked with final state
Added by Tom Morris almost 8 years ago.
Updated almost 8 years ago.
- Target version set to Arvados Future Sprints
- Story points set to 0.5
If the client provides no end time or it's null then the API server fills in the current time.
- Target version changed from Arvados Future Sprints to 2017-01-04 sprint
- Assigned To set to Lucas Di Pentima
- Status changed from New to In Progress
I think it would be good to ensure started_at isn't nil when changing state to Failed or Complete too, in case a client creates a new object with state=Complete.
I don't think it would affect anything in practice as things stand, but I think conceptually (and for the sake of our future selves) this should be before_validation rather than before_save -- e.g., if we were validating started_at and finished_at, we would want to validate after applying these defaults, not after.
other than those points, LGTM
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:96d90c859cede094d83cbaf5409418e9ab0c2c19.
Also available in: Atom
PDF