https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-12-07T15:33:27ZArvadosArvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=461202016-12-07T15:33:27ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/46120/diff?detail_id=44396">diff</a>)</li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=461212016-12-07T15:34:38ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Subject</strong> changed from <i>Copy and re-run container request</i> to <i>[Workbench] Copy and re-run container request</i></li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464002016-12-14T20:38:34ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Target version</strong> set to <i>2017-01-04 sprint</i></li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464012016-12-14T20:38:46ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Assigned To</strong> set to <i>Radhika Chippada</i></li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464432016-12-15T14:43:03ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464532016-12-15T18:44:36ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Description</strong> updated (<a title="View differences" href="/journals/46453/diff?detail_id=44720">diff</a>)</li></ul> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464812016-12-16T15:50:29ZLucas Di Pentimalucas.dipentima@curii.com
<ul></ul><p>LGTM, just found a typo on a comment on <code>apps/workbench/app/controllers/container_requests_controller.rb:82</code>: 'wriable' (same one as in <code>pipeline_instance_controller</code>)</p>
<p>Was going to ask why we're creating a new instance and then doing an object duplication on ApplicationController's copy method, but then I saw that this is based on the same method existing on pipeline_instance, so I imagine that there's a good reason for doing it that way.</p> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464832016-12-16T15:58:44ZRadhika Chippadaradhika@curoverse.com
<ul></ul><p>Fixed the typo.</p>
<p>Regarding "why we're creating a new instance and then doing an object duplication": This is not exactly a pure "copy" we are doing, but copy the state with the run results. Especially in this case, we are making a copy of the object and re-running it. I guess a "copy-to-rerun" or "copy-initial-state" would have been a better name for this "copy" method instead.</p>
<p>Thanks.</p> Arvados - Feature #10677: [Workbench] Copy and re-run container requesthttps://dev.arvados.org/issues/10677?journal_id=464892016-12-16T16:05:06ZRadhika Chippadaradhika@curoverse.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:ccc1201e103e168b04801b135b662577d7ea475b.</p>