Project

General

Profile

Actions

Story #10681

closed

[CWL] arvados-cwl-runner should support --name flag

Added by Tom Morris about 7 years ago. Updated about 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
12/07/2016
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Description

The current scheme of naming all jobs the same as the CWL file that they're running makes it difficult to distinguish jobs from each other if, for example, one has many runs of the same workflow with different inputs.


Subtasks 2 (0 open2 closed)

Task #10685: Review 10681-cwl-name-flagResolvedTom Clegg12/07/2016

Actions
Task #10688: Review 10681-cwl-wf-name-flagResolvedPeter Amstutz12/07/2016

Actions
Actions #1

Updated by Peter Amstutz about 7 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Tom Clegg about 7 years ago

Just nits,

Would this

"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),

be better as

"name": kwargs.get("name", shortname(tool.tool["id"])),

?

Worth adding a test assertion somewhere for the default/previous name behavior?

LGTM

Actions #3

Updated by Peter Amstutz about 7 years ago

Tom Clegg wrote:

Just nits,

Would this

"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),

be better as

"name": kwargs.get("name", shortname(tool.tool["id"])),

No, because kwargs.get("name") when kwargs contains {"name": None} will yield None, not the default value.

Worth adding a test assertion somewhere for the default/previous name behavior?

The existing tests that don't specify --name already assert the previous behavior.

LGTM

Actions #4

Updated by Peter Amstutz about 7 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:3e6ad647c3da4cb77299249d1fa25767dc66b281.

Actions #5

Updated by Peter Amstutz about 7 years ago

  • Status changed from Resolved to Feedback
Actions #6

Updated by Radhika Chippada about 7 years ago

Branch 10681-cwl-wf-name-flag

  • I think it would be useful to also test updating a workflow / template with name?
  • It seems like test_create and test_create_name repeat a log of the code; wondering if code can be refactored and reused than repeated?

LGTM one way or the other. Thanks.

Actions #7

Updated by Peter Amstutz about 7 years ago

  • Status changed from Feedback to Resolved
  • % Done changed from 50 to 100

Applied in changeset arvados|commit:b8e3dea8979a7dbbdb62b8ecd47f7094a7f0863c.

Actions

Also available in: Atom PDF