https://dev.arvados.org/https://dev.arvados.org/favicon.ico?15576888422016-12-07T20:10:11ZArvadosArvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461462016-12-07T20:10:11ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461562016-12-07T21:16:46ZTom Cleggtom@curii.com
<ul></ul><p>Just nits,</p>
<p>Would this</p>
<pre><code>"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),</code></pre>
<p>be better as</p>
<pre><code>"name": kwargs.get("name", shortname(tool.tool["id"])),</code></pre>
<p>?</p>
<p>Worth adding a test assertion somewhere for the default/previous name behavior?</p>
<p>LGTM</p> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461572016-12-07T21:23:39ZPeter Amstutzpeter.amstutz@curii.com
<ul></ul><p>Tom Clegg wrote:</p>
<blockquote>
<p>Just nits,</p>
<p>Would this</p>
<p>"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),</p>
<p>be better as</p>
<p>"name": kwargs.get("name", shortname(tool.tool["id"])),</p>
</blockquote>
<p>No, because <code>kwargs.get("name")</code> when kwargs contains <code>{"name": None}</code> will yield <code>None</code>, not the default value.</p>
<blockquote>
<p>Worth adding a test assertion somewhere for the default/previous name behavior?</p>
</blockquote>
<p>The existing tests that don't specify <code>--name</code> already assert the previous behavior.</p>
<blockquote>
<p>LGTM</p>
</blockquote> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461632016-12-07T21:35:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Resolved</i></li></ul><p>Applied in changeset arvados|commit:3e6ad647c3da4cb77299249d1fa25767dc66b281.</p> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461812016-12-08T16:18:51ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>Resolved</i> to <i>Feedback</i></li></ul> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461892016-12-08T17:20:17ZRadhika Chippadaradhika@curoverse.com
<ul></ul><p>Branch 10681-cwl-wf-name-flag</p>
<ul>
<li>I think it would be useful to also test updating a workflow / template with name?</li>
</ul>
<ul>
<li>It seems like test_create and test_create_name repeat a log of the code; wondering if code can be refactored and reused than repeated?</li>
</ul>
<p>LGTM one way or the other. Thanks.</p> Arvados - Idea #10681: [CWL] arvados-cwl-runner should support --name flaghttps://dev.arvados.org/issues/10681?journal_id=461912016-12-08T19:15:05ZPeter Amstutzpeter.amstutz@curii.com
<ul><li><strong>Status</strong> changed from <i>Feedback</i> to <i>Resolved</i></li><li><strong>% Done</strong> changed from <i>50</i> to <i>100</i></li></ul><p>Applied in changeset arvados|commit:b8e3dea8979a7dbbdb62b8ecd47f7094a7f0863c.</p>