Idea #10681
closed
[CWL] arvados-cwl-runner should support --name flag
Added by Tom Morris over 7 years ago.
Updated over 7 years ago.
Description
The current scheme of naming all jobs the same as the CWL file that they're running makes it difficult to distinguish jobs from each other if, for example, one has many runs of the same workflow with different inputs.
- Status changed from New to In Progress
Just nits,
Would this
"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),
be better as
"name": kwargs.get("name", shortname(tool.tool["id"])),
?
Worth adding a test assertion somewhere for the default/previous name behavior?
LGTM
Tom Clegg wrote:
Just nits,
Would this
"name": kwargs["name"] if kwargs.get("name") else shortname(tool.tool["id"]),
be better as
"name": kwargs.get("name", shortname(tool.tool["id"])),
No, because kwargs.get("name") when kwargs contains {"name": None} will yield None, not the default value.
Worth adding a test assertion somewhere for the default/previous name behavior?
The existing tests that don't specify --name already assert the previous behavior.
LGTM
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:3e6ad647c3da4cb77299249d1fa25767dc66b281.
- Status changed from Resolved to Feedback
Branch 10681-cwl-wf-name-flag
- I think it would be useful to also test updating a workflow / template with name?
- It seems like test_create and test_create_name repeat a log of the code; wondering if code can be refactored and reused than repeated?
LGTM one way or the other. Thanks.
- Status changed from Feedback to Resolved
- % Done changed from 50 to 100
Applied in changeset arvados|commit:b8e3dea8979a7dbbdb62b8ecd47f7094a7f0863c.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by Radhika Chippada