Bug #10793

[CWL] Continue submitting jobs on error

Added by Peter Amstutz over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
01/06/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #10814: Review 10793-cwl-continue-on-errorResolvedPeter Amstutz

Associated revisions

Revision 495a7df0
Added by Peter Amstutz over 4 years ago

Merge branch '10793-cwl-continue-on-error' closes #10793

History

#1 Updated by Peter Amstutz over 4 years ago

  • Status changed from New to In Progress

#2 Updated by Peter Amstutz over 4 years ago

  • Target version changed from Arvados Future Sprints to 2017-01-18 sprint

#3 Updated by Peter Amstutz over 4 years ago

  • Assigned To set to Peter Amstutz

#6 Updated by Peter Amstutz over 4 years ago

Whoops, there were failing tests. Should be fixed:

https://ci.curoverse.com/job/developer-run-tests/129/

#7 Updated by Lucas Di Pentima over 4 years ago

Just one comment:

  • sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.

Apart from that, lgtm.

#8 Updated by Peter Amstutz over 4 years ago

Lucas Di Pentima wrote:

Just one comment:

  • sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.

Apart from that, lgtm.

Good catch, thanks for that. Done.

#9 Updated by Peter Amstutz over 4 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:495a7df016f63ae348000b1c046f8e1c5f1c5903.

Also available in: Atom PDF