Actions
Bug #10793
closed
[CWL] Continue submitting jobs on error
Story points:
0.5
Updated by Peter Amstutz over 7 years ago
- Status changed from New to In Progress
Updated by Peter Amstutz over 7 years ago
- Target version changed from Arvados Future Sprints to 2017-01-18 sprint
Updated by Peter Amstutz over 7 years ago
Manually tested using these (deliberately failing) workflows:
https://github.com/common-workflow-language/cwltool/blob/master/tests/wf/scatterfail.cwl
https://github.com/common-workflow-language/cwltool/blob/master/tests/wf/wffail.cwl
Updated by Peter Amstutz over 7 years ago
Developer tests https://ci.curoverse.com/job/developer-run-tests/128/
Updated by Peter Amstutz over 7 years ago
Whoops, there were failing tests. Should be fixed:
Updated by Lucas Di Pentima over 7 years ago
Just one comment:
- sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.
Apart from that, lgtm.
Updated by Peter Amstutz over 7 years ago
Lucas Di Pentima wrote:
Just one comment:
- sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.
Apart from that, lgtm.
Good catch, thanks for that. Done.
Updated by Peter Amstutz over 7 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|commit:495a7df016f63ae348000b1c046f8e1c5f1c5903.
Actions