Arvados

Manually tested using these (deliberately failing) workflows:

https://github.com/common-workflow-language/cwltool/blob/master/tests/wf/scatterfail.cwl

https://github.com/common-workflow-language/cwltool/blob/master/tests/wf/wffail.cwl

Developer tests https://ci.curoverse.com/job/developer-run-tests/128/

Whoops, there were failing tests. Should be fixed:

https://ci.curoverse.com/job/developer-run-tests/129/

Just one comment:

• sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.

Apart from that, lgtm.

Lucas Di Pentima wrote:

Just one comment:

• sdk/cwl/arvados_cwl/crunch_script.py - Line 94: Maybe it’s convenient to declare on_error outside the if statement (line 83) just in case in the future that conditional is not met.

Apart from that, lgtm.

Good catch, thanks for that. Done.