Arvados

The branch 10812-similar-collections-check lgtm @ a6afada6

• in init.py, --submit-runner-image: wondering if --submit-job-image rather than introducing yet another word to the end user

• In init.py, please undo this indentation update
  

  @@ -177,7 +177,7 @@ class ArvCwlRunner(object): 
                   for p in proc_states["items"]:
                       self.on_message({
  -                        "object_uuid": p["uuid"],
  +                       "object_uuid": p["uuid"],
                           "event_type": "update",
  

• In done.py : Can “logtail = []” in the method logtail be renamed so that it is not confusing?

• In done.py : extra set of parentheses in “logt.append((g.group(1), g.group(2)))”

• In fsaccess.py “record = self.api_client.workflows().get(uuid=url[6:]).execute()” : do we want to specify num_retries?

• One sdk/cwl test was failing for me yesterday with run-tests, but not anymore. Please make sure they are all passing after you merge all the three branches.

Radhika Chippada wrote:

• in init.py, --submit-runner-image: wondering if --submit-job-image rather than introducing yet another word to the end user

I named it that way because there is a similar option --submit-runner-ram.

This reminds me that I should probably add a test, too.

• In init.py, please undo this indentation update
  [...]

Fixed.

• In done.py : Can “logtail = []” in the method logtail be renamed so that it is not confusing?

You're right. Renamed to "loglines".

• In done.py : extra set of parentheses in “logt.append((g.group(1), g.group(2)))”

No, the extra set of parenthesis make it a Python tuple. So it is not appending two items, it is appending one item which is a tuple.

• In fsaccess.py “record = self.api_client.workflows().get(uuid=url[6:]).execute()” : do we want to specify num_retries?

Yes, will do.

• One sdk/cwl test was failing for me yesterday with run-tests, but not anymore. Please make sure they are all passing after you merge all the three branches.

Yes, I did fix one failing test since last night when I asked you to review.

Updated 10812-submit-runner-image with tests, now 1cdb5cbf83d34cb1a19c78478a7d5a28738e7bbf

Updated 10812-log-merge now e8521124b0b8e647c58e99905100171ea5e30abd

Updated 10812-cwl-separate-dependencies now 1bf2e116aae97f0a6a9ed0962cd74e092e3b4695 running tests https://ci.curoverse.com/job/developer-run-tests/145/

In fsaccess.py “record = self.api_client.workflows().get(uuid=url[6:]).execute()” : do we want to specify num_retries?

Fixed in 10812-cwl-separate-dependencies dc17bad908428e268b8ac1cab966902ce4c67d03