Feature #10830

[Workbench] Support array type input parameters to Workflows

Added by Peter Amstutz almost 2 years ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Story points:
-

Description

Users cannot edit array type input parameters in Workbench:

Unable to render editing control for parameter type {:items=>"File", :type=>"array"}

Workbench needs an editing control that supports editing array inputs.

CWL array input - mockup.jpg (56.2 KB) CWL array input - mockup.jpg Radhika Chippada, 01/18/2017 01:35 PM

History

#1 Updated by Peter Amstutz almost 2 years ago

  • Description updated (diff)

#2 Updated by Radhika Chippada almost 2 years ago

Does an array contain a single data type such as a string or an int or another array of type x etc? Or does one array can contain multiple types? If so how is it used (example)?

http://www.commonwl.org/draft-3/UserGuide.html#Array_inputs

http://www.commonwl.org/draft-3/CommandLineTool.html#CommandInputRecordSchema

#3 Updated by Radhika Chippada almost 2 years ago

During yesterday's grooming meeting, we agreed that we will support arrays containing single item types or other arrays (which in turn will contain single item types) to start with.

#4 Updated by Radhika Chippada almost 2 years ago

  • Support arrays with single item types such as string, int, array etc
    • Support item types boolean, int, long, float, double, string, File, Directory
  • Adding input items: for each array type input:
    • Present a "Add new item" button
    • When this button is pressed, add an input field of appropriate type such as text field or collection file chooser etc (see the "CWL array input - mockup")
  • When displaying a previously saved CR:
    • Add required number of items of type and pre-populate them with the data in the CR
  • Clearing previous data
    • When text in a populated input item is cleared, remove it from the array during save
  • Do we need to support any other types other than boolean, int, long, float, double, string, File, Directory?

#5 Updated by Peter Amstutz almost 2 years ago

Radhika Chippada wrote:

  • Support arrays with single item types such as string, int, array etc
    • Support item types boolean, int, long, float, double, string, File, Directory
  • Adding input items: for each array type input:
    • Present a "Add new item" button
    • When this button is pressed, add an input field of appropriate type such as text field or collection file chooser etc (see the "CWL array input - mockup")
  • When displaying a previously saved CR:
    • Add required number of items of type and pre-populate them with the data in the CR
  • Clearing previous data
    • When text in a populated input item is cleared, remove it from the array during save

Maybe have a an [X] or trash button to delete array entries?

  • Do we need to support any other types other than boolean, int, long, float, double, string, File, Directory?

We're not doing complex types (nested arrays/records) for this ticket, so no.

You're looking at the wrong spec version. The right one is here: http://www.commonwl.org/v1.0/CommandLineTool.html#CWLType

#6 Updated by Tom Morris over 1 year ago

  • Assigned To set to Tom Morris
  • Target version set to Arvados Future Sprints

Also available in: Atom PDF