Bug #10877

[Keep] Configurable base URL for Azure storage driver

Added by Tom Clegg over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Keep
Target version:
Start date:
01/12/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks

Task #10878: Review 10877-azure-base-urlResolvedRadhika Chippada

Associated revisions

Revision a6f28990
Added by Tom Clegg over 4 years ago

Merge branch '10877-azure-base-url'

closes #10877

History

#1 Updated by Tom Clegg over 4 years ago

  • Category set to Keep
  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg

#2 Updated by Radhika Chippada over 4 years ago

LGTM @ f892f08b

Just one suggestion. It would be nice to add a comment in examples, something as follows:

--- a/services/keepstore/azure_blob_volume.go
+++ b/services/keepstore/azure_blob_volume.go
@@ -110,6 +110,7 @@ type AzureBlobVolume struct {
 // Examples implements VolumeWithExamples.
 func (*AzureBlobVolume) Examples() []Volume {
        return []Volume{
+               // Blob volume with default StorageBaseURL
                &AzureBlobVolume{
                        StorageAccountName:    "example-account-name",
                        StorageAccountKeyFile: "/etc/azure_storage_account_key.txt",
@@ -117,6 +118,7 @@ func (*AzureBlobVolume) Examples() []Volume {
                        AzureReplication:      3,
                        RequestTimeout:        azureDefaultRequestTimeout,
                },
+               // Blob volume for China
                &AzureBlobVolume{
                        StorageAccountName:    "cn-account-name",
                        StorageAccountKeyFile: "/etc/azure_cn_storage_account_key.txt",

#3 Updated by Tom Clegg over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:a6f289904b3960a9ffaf4be453ce82d3757fba23.

#4 Updated by Nico César over 4 years ago

Germany will be another entry there and probably .

#5 Updated by Nico César over 4 years ago

is there a command line parameter too?

2017-01-13_14:20:35.64862 Starting keepstore from /etc/sv/keepstore
2017-01-13_14:20:35.67242 flag provided but not defined: -azure-storage-base-url

Also available in: Atom PDF