Arvados

LGTM @ f892f08b

Just one suggestion. It would be nice to add a comment in examples, something as follows:

--- a/services/keepstore/azure_blob_volume.go
+++ b/services/keepstore/azure_blob_volume.go
@@ -110,6 +110,7 @@ type AzureBlobVolume struct {
 // Examples implements VolumeWithExamples.
 func (*AzureBlobVolume) Examples() []Volume {
        return []Volume{
+               // Blob volume with default StorageBaseURL
                &AzureBlobVolume{
                        StorageAccountName:    "example-account-name",
                        StorageAccountKeyFile: "/etc/azure_storage_account_key.txt",
@@ -117,6 +118,7 @@ func (*AzureBlobVolume) Examples() []Volume {
                        AzureReplication:      3,
                        RequestTimeout:        azureDefaultRequestTimeout,
                },
+               // Blob volume for China
                &AzureBlobVolume{
                        StorageAccountName:    "cn-account-name",
                        StorageAccountKeyFile: "/etc/azure_cn_storage_account_key.txt",

Germany will be another entry there and probably .

is there a command line parameter too?

2017-01-13_14:20:35.64862 Starting keepstore from /etc/sv/keepstore
2017-01-13_14:20:35.67242 flag provided but not defined: -azure-storage-base-url