Bug #10945

[Workbench] No way to navigate from CWL job to its parent

Added by Tom Morris over 2 years ago. Updated over 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
01/21/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

The job page has a "Used in pipelines" section at the bottom, but this is always empty for jobs from CWL workflows. There needs to be a way to navigate up from here.

Update Workunit API to cover non-pipelines.


Subtasks

Task #11039: Review branch 10945-used-in-section-for-cwl-jobsResolvedLucas Di Pentima

Associated revisions

Revision 35ae0e8d
Added by Radhika Chippada over 2 years ago

closes #10945
Merge branch '10945-used-in-section-for-cwl-jobs'

History

#1 Updated by Tom Morris over 2 years ago

  • Description updated (diff)
  • Story points set to 1.0

#2 Updated by Tom Clegg over 2 years ago

  • Subject changed from [Workbench] No way to navigate from CWL job to it's parent to [Workbench] No way to navigate from CWL job to its parent

#3 Updated by Radhika Chippada over 2 years ago

  • Assigned To set to Radhika Chippada

#4 Updated by Radhika Chippada over 2 years ago

From IRC:

radhika
3:51 tom: just one quick question about 10945. looking at the code, the resolution for this issue would be to look for jobs whose components include "this job" (in addition to the current check of pipelines). right?

tom
4:15 radhika: re 10945, yes, sounds right.

#5 Updated by Radhika Chippada over 2 years ago

Branch 10945-used-in-section-for-cwl-jobs @ 78b94fd adds a "used in jobs" section to job#show page. I noticed a job may have been "used in" 100s of other jobs. Hence, I displayed only the most recent 10 jobs, similar to views/collections/hash_matches.html.erb page.

To manually test: In 4xphq, jobs/4xphq-8i9sb-u4x3qrdh4xhzuja has "used in pipelines" section content and jobs/4xphq-8i9sb-asb2clkxrtk4ree has "used in jobs" content populated

#6 Updated by Lucas Di Pentima over 2 years ago

  • Status changed from New to In Progress

#7 Updated by Lucas Di Pentima over 2 years ago

Some small details:

  • File apps/workbench/app/views/jobs/_show_status.html.erb
    • Line 27: Maybe the word “the” should be eliminated from this title.
    • Line 36: I think that <div> is not being closed.
  • When a job is not used in pipelines, maybe we can hide that panel instead of showing it empty? Or the other way around for “used in jobs” panel, that is to show it empty when not used in any job? for consistency purposes.
  • Is it possible for a job to be used by lots of pipelines like with other jobs? If yes, we could limit that query.

#8 Updated by Radhika Chippada over 2 years ago

In _show_status.html.erb Line 27: Maybe the word “the” should be eliminated from this title.

Updated

In _show_status.html.erb Line 36: I think that <div> is not being closed.

Thanks for catching this. Corrected

When a job is not used in pipelines, maybe we can hide that panel instead of showing it empty? Or the other way around for “used in jobs” panel, that is to show it empty when not used in any job? for consistency purposes.

The pipeline display is a bit tricky. Even when the query 'PipelineInstance.order("created_at desc").filter("components", "like", "%)' returns some responses, they may not match the conditional in line 12 and hence does not aid us to say "n number are not listed" like in the case of jobs. Hence, I took your other suggestion and showing the "Used in jobs" panel always similar to "Used in pipelines" panel

Is it possible for a job to be used by lots of pipelines like with other jobs? If yes, we could limit that query.

As explained above, this is not as straight forward as the case of jobs. It didn't appear that this was causing performance problems before either and hence leaving it as it was before.

Thanks.

#9 Updated by Lucas Di Pentima over 2 years ago

LGTM, please merge.

#10 Updated by Radhika Chippada over 2 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:35ae0e8d87dde84dd3a0ab41cef9567ab93b042a.

Also available in: Atom PDF