Project

General

Profile

Actions

Bug #11014

closed

[Workbench] Hide the "idle/busy nodes" part of the dashboard if crunch1 APIs are disabled

Added by Tom Clegg almost 6 years ago. Updated over 5 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
03/17/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
0.5

Subtasks 1 (0 open1 closed)

Task #11268: Review 11014-hide-node-statusResolvedLucas Di Pentima03/17/2017

Actions

Related issues

Related to Arvados - Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not activeResolvedTom Clegg09/30/2019

Actions
Related to Arvados - Bug #15036: [Crunch2] Idle/busy node count not accurate if crunch1 not runningDuplicate

Actions
Actions #1

Updated by Tom Morris almost 6 years ago

  • Story points set to 0.5
Actions #2

Updated by Tom Morris over 5 years ago

  • Target version set to 2017-03-29 sprint
Actions #3

Updated by Lucas Di Pentima over 5 years ago

  • Assigned To set to Lucas Di Pentima
Actions #4

Updated by Lucas Di Pentima over 5 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Lucas Di Pentima over 5 years ago

Updates on branch 11014-hide-node-status at 73dbf5b
Tests run at: https://ci.curoverse.com/job/developer-run-tests/191/

Used the already existing ArvadosBase.api_exists?() method on the dashboard template partial to decide whether to render or not the compute node status pane.

Actions #7

Updated by Radhika Chippada over 5 years ago

  • Rather than executing “PipelineInstance.api_exists?” multiple times, can we declare a variable such as “show_node_status” at line 30?
  • This I am not sure if you would like to address or not, but I’d mention it. If NOT PipelineInstance.api_exists? AND NOT Rails.configuration.show_recent_collections_on_dashboard, the left pane that shows processes is squished to the left half. It looked really bad! Should we declare panel_width = 6 or 12 before line 37 depending on this IF condition and use it at lines 38 and 98?
    div class="col-md-6"
  • test “dashboard compute node status when …” => Can you say something like “dashboard compute nodes not shown when …”

LGTM as you like.

Actions #8

Updated by Lucas Di Pentima over 5 years ago

Thanks for the comments, all addressed at bf03dd4

Test run: https://ci.curoverse.com/job/developer-run-tests/193/

Actions #9

Updated by Lucas Di Pentima over 5 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:47178c71032b476e34fd0c6b10065e1b96a568f1.

Actions #10

Updated by Tom Clegg over 3 years ago

  • Related to Bug #15014: [Workbench] Hide busy/idle nodes display when crunch1 is not active added
Actions #11

Updated by Tom Morris over 3 years ago

  • Related to Bug #15036: [Crunch2] Idle/busy node count not accurate if crunch1 not running added
Actions

Also available in: Atom PDF