Bug #11014

[Workbench] Hide the "idle/busy nodes" part of the dashboard if crunch1 APIs are disabled

Added by Tom Clegg 9 months ago. Updated 7 months ago.

Status:ResolvedStart date:03/17/2017
Priority:NormalDue date:
Assignee:Lucas Di Pentima% Done:

100%

Category:-
Target version:2017-03-29 sprint
Story points0.5Remaining (hours)0.00 hour
Velocity based estimate0 days

Subtasks

Task #11268: Review 11014-hide-node-statusResolvedLucas Di Pentima

Associated revisions

Revision 47178c71
Added by Lucas Di Pentima 7 months ago

Merge branch '11014-hide-node-status'
Closes #11014

History

#1 Updated by Tom Morris 9 months ago

  • Story points set to 0.5

#2 Updated by Tom Morris 7 months ago

  • Target version set to 2017-03-29 sprint

#3 Updated by Lucas Di Pentima 7 months ago

  • Assignee set to Lucas Di Pentima

#4 Updated by Lucas Di Pentima 7 months ago

  • Status changed from New to In Progress

#5 Updated by Lucas Di Pentima 7 months ago

Updates on branch 11014-hide-node-status at 73dbf5b
Tests run at: https://ci.curoverse.com/job/developer-run-tests/191/

Used the already existing ArvadosBase.api_exists?() method on the dashboard template partial to decide whether to render or not the compute node status pane.

#7 Updated by Radhika Chippada 7 months ago

  • Rather than executing “PipelineInstance.api_exists?” multiple times, can we declare a variable such as “show_node_status” at line 30?
  • This I am not sure if you would like to address or not, but I’d mention it. If NOT PipelineInstance.api_exists? AND NOT Rails.configuration.show_recent_collections_on_dashboard, the left pane that shows processes is squished to the left half. It looked really bad! Should we declare panel_width = 6 or 12 before line 37 depending on this IF condition and use it at lines 38 and 98?
    div class="col-md-6"
  • test “dashboard compute node status when …” => Can you say something like “dashboard compute nodes not shown when …”

LGTM as you like.

#8 Updated by Lucas Di Pentima 7 months ago

Thanks for the comments, all addressed at bf03dd4

Test run: https://ci.curoverse.com/job/developer-run-tests/193/

#9 Updated by Lucas Di Pentima 7 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:47178c71032b476e34fd0c6b10065e1b96a568f1.

Also available in: Atom PDF