[Workbench] Hide the "idle/busy nodes" part of the dashboard if crunch1 APIs are disabled
#5 Updated by Lucas Di Pentima 11 months ago
Updates on branch
11014-hide-node-status at 73dbf5b
Tests run at: https://ci.curoverse.com/job/developer-run-tests/191/
Used the already existing
ArvadosBase.api_exists?() method on the dashboard template partial to decide whether to render or not the compute node status pane.
#6 Updated by Lucas Di Pentima 11 months ago
Re-ran the tests here: https://ci.curoverse.com/job/developer-run-tests/192/
#7 Updated by Radhika Chippada 11 months ago
- Rather than executing “PipelineInstance.api_exists?” multiple times, can we declare a variable such as “show_node_status” at line 30?
- This I am not sure if you would like to address or not, but I’d mention it. If NOT PipelineInstance.api_exists? AND NOT Rails.configuration.show_recent_collections_on_dashboard, the left pane that shows processes is squished to the left half. It looked really bad! Should we declare panel_width = 6 or 12 before line 37 depending on this IF condition and use it at lines 38 and 98?
- test “dashboard compute node status when …” => Can you say something like “dashboard compute nodes not shown when …”
LGTM as you like.
#8 Updated by Lucas Di Pentima 11 months ago
Thanks for the comments, all addressed at bf03dd4