Arvados

Having two different page layouts seems unnecessary to me, but each is currently missing some important pieces.

- Individual repositories page is missing delete (as you point out) and "show" is non-obviously hidden behind the "Share" button
- All repositories page is missing URLs and "Share" is hidden behind "Show"

I think my preference would be to use the individual repositories page as a base, but make the columns consistent with ordering on other pages (e.g. collections), so that we have

Trashcan "Show" <username>/<reponame> <cloning URLs>
icon

I think that layout will work for both pages.

Workbench is only listing repositories with direct ownership and direct permission links. It is doing this (instead of just getting the straight repository listing) because we want to show whether the user has read/write/manage permission on each repository.

It would be more consistent to be able to query the repository with a normal listing, and have that include virtual fields indicating whether the current user has write/manage access to each repo.

Groups include a meta-field called "writable_by". Perhaps repositories return this field as well?

Before I forget:

In terms of layout, instead of a "Show" button can we have the following two buttons:

1. "Browse" which links to /repositories/zzzzz-s0uqq-zzzzzzzzzzzzzz/tree/master
2. "Share" which links to /repositories/zzzzz-s0uqq-zzzzzzzzzzzzzz#Sharing

Peter Amstutz wrote:

Groups include a meta-field called "writable_by". Perhaps repositories return this field as well?

I expect we merely have to add "t.add :writable_by" to source:services/api/app/models/repository.rb (as we do in source:services/api/app/models/group.rb). The method is in ArvadosModel.

On further inspection, currently it does not display whether you have read/write/manage access to each repository. So it should be correct to just get repository list readable by the current user and not apply any additional filtering.

Comments / recommendations:

    all_repositories = Hash[Repository.where(authorized_user_uuid: current_user.uuid).collect {|repo| [repo.uuid, repo]}]

The field authorized_user_uuid only exists for authorized_keys, not repositories. It seems to be entirely ignored here. Looks like a copy-and-paste error. Also we should sort by repository name:

    all_repositories = Hash[Repository.order(:name).all.collect {|repo| [repo.uuid, repo]}]

Let's get rid of this the query for "repo_links". It only returns direct permission links and not transitive permissions, so the sorting will be inconsistent depending on whether the permission is direct or indirect. Prefer the simpler sort order of [my repositories, everything else].

Because we're just displaying "Repository.all" (and there's no way to filter on "readable by user in param[:uuid]") the entire page should move to "/repositories" and the page under /users/<uuid>/repositories" should go away.

For layout, instead of (or in addition to) the "Show" button we I would like to see the following two buttons:

1. "Browse" which links to /repositories/zzzzz-s0uqq-zzzzzzzzzzzzzz/tree/master
2. "Share" which links to /repositories/zzzzz-s0uqq-zzzzzzzzzzzzzz#Sharing

There needs to be a test that a repository shared with "all users" (but not directly with the user) shows up in the user's repository list.

@ 1883b07d5de707066bf996c1526073df323c3991

all_repositories = Hash[Repository.order(:name).all.collect {|repo| [repo.uuid, repo]}]

Done

Let's get rid of this the query for "repo_links" ...

Updated sorting accordingly

the entire page should move to "/repositories" and the page under /users/<uuid>/repositories" should go away

Since this involves tweaking / moving several files and logic from users controller and user views, and updating tests accordingly, I created a new ticket for this. #11870

"Browse" link

The <repo_uuid>/tree/master is not accessible for all repositories and I am getting 404 errors. I also think a new tab or direct link in the repository Show page itself, after determining it is available for that repo, is a better place for this functionality. Added #11871

"Share" link

As Tom Morris said in his note 7, the Share tab is available once the user clicks and transitions into the repo show page. Also per your note 14, we cannot accurately determine the access level for each repository. Hence, I am omitting this as well in favor of Show link.

Tests

Added the check to "arvados" repository, which is shared with all_users.

Test run @ https://ci.curoverse.com/job/developer-run-tests/337/

Thanks.

• This doesn't seem to work (it's not actually ordered by name):

Hash[Repository.all.order(:name).collect {|repo| [repo.uuid, repo]}]

But this works:

Hash[Repository.order('name asc').collect {|repo| [repo.uuid, repo]}]

• The link "For more information see Writing a pipeline." goes to "/user/tutorials/tutorial-firstscript.html" which at the top says "Arvados pipeline templates are deprecated."

I think we can safely remove that link from the repositories page.

• The delete dialog box says "Really delete repositories?" which is confusing (we're only deleting one repository). It should say "Really delete repository <name>?"

• There's no infinite scrolling / paging. On qr1hi, admins can see almost 1000 repositories. The page renders fast enough that I don't think it is a problem right now, but just wanted to mention it.

@ 9318b234cbfae138524e45080f549c277e15776b

This works: Hash[Repository.order('name asc').collect {|repo| [repo.uuid, repo]}]

Ah, yes, I noticed this but later forgot to correct it as I was working on all other items in the note. Thanks.

The link "For more information see Writing a pipeline." goes to "/user/tutorials/tutorial-firstscript.html" which at the top says "Arvados pipeline templates are deprecated." ...I think we can safely remove that link from the repositories page.

Removed this

The delete dialog box says "Really delete repositories?" which is confusing (we're only deleting one repository). It should say "Really delete repository <name>?"

Corrected this

There's no infinite scrolling / paging. On qr1hi, admins can see almost 1000 repositories. The page renders fast enough that I don't think it is a problem right now, but just wanted to mention it.

Since we want to move this functionality into /repositories page, I added a note to #11870 to this effect.

Thanks.