Story #11167

[Workbench] Remove arv-get file download fallback

Added by Peter Amstutz 4 months ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:Arvados Future Sprints
Story points1.0
Velocity based estimate-

Description

Currently, if keep-web isn't configured, Workbench will fallback to arv-get and Rails streaming to serve files. However, this is a very bad fallback:

  1. It fails silently if calling arv-get doesn't work
  2. It ties up a workbench worker for the duration of the download
  3. It doesn't report content-length, so user agents are unable to render a progress bar or determine if the entire file was transferred.
  4. It sometimes silently drops out in the middle of downloads
  5. It sometimes consumes huge amount of RAM, crashing the workbench server.
  6. It can't handle [some?] range requests

Instead we should:
- Workbench should refuse start if keep-web is not configured
- Documentation should be updated to emphasize that keep-web is mandatory, Workbench config for keep-web, and the new Workbench startup failure mode
- Remove the arv-get fallback code and adjust any related tests
- For file downloads, prefer to link directly to keep-web instead of redirecting through workbench (especially useful for sharing links)


Related issues

Related to Arvados - Story #8784: [Workbench] Use keep-web to generate directory listings In Progress 03/23/2016

History

#1 Updated by Peter Amstutz 4 months ago

  • Description updated (diff)

#2 Updated by Tom Clegg 4 months ago

  • Description updated (diff)

#3 Updated by Tom Morris 4 months ago

  • Description updated (diff)
  • Target version set to 2017-03-15 sprint
  • Story points set to 1.0

#4 Updated by Tom Morris 4 months ago

  • Target version changed from 2017-03-15 sprint to Arvados Future Sprints

#5 Updated by Peter Amstutz about 1 month ago

  • Description updated (diff)

Also available in: Atom PDF