Project

General

Profile

Actions

Idea #11167

closed

[Workbench] Remove arv-get file download fallback

Added by Peter Amstutz about 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
1.0

Description

Currently, if keep-web isn't configured, Workbench will fallback to arv-get and Rails streaming to serve files. However, this is a very bad fallback:

  1. It fails silently if calling arv-get doesn't work
  2. It ties up a workbench worker for the duration of the download
  3. It doesn't report content-length, so user agents are unable to render a progress bar or determine if the entire file was transferred.
  4. It sometimes silently drops out in the middle of downloads
  5. It sometimes consumes huge amount of RAM, crashing the workbench server.
  6. It can't handle [some?] range requests

Instead we should:
- Workbench should refuse start if keep-web is not configured <- see note#22
- Documentation should be updated to emphasize that keep-web is mandatory, Workbench config for keep-web, and the new Workbench startup failure mode
- Remove the arv-get fallback code and adjust any related tests
- For file downloads, prefer to link directly to keep-web instead of redirecting through workbench (especially useful for sharing links) (done in #8784)


Subtasks 1 (0 open1 closed)

Task #11937: Review 11167-wb-remove-arvgetResolvedLucas Di Pentima07/24/2017Actions

Related issues

Related to Arvados - Idea #8784: [Workbench] Use keep-web to generate directory listingsResolvedTom Clegg03/23/2016Actions
Related to Arvados - Bug #17528: [Rails] package prints a backtrace on installation when the arvados config.yml file is not present/completeResolvedTom Clegg04/15/2021Actions
Actions

Also available in: Atom PDF