Arvados

Branch 11465-disabled-collection-file-tooltips

Tests passed @ https://ci.curoverse.com/job/developer-run-tests/233/

Although when hovering the buttons with the mouse it shows the tooltip and the prohibited sign, it’s accepting my clicks on both the rename pencil and the trash button.

The Upload tab also seems to accept the click event because the #Upload string it's being added on the browser's URL bar, but the page behaves correctly as it doesn't show the Upload pane, but if I click "reload" having the #Upload string on the URL, the Upload pane does show. (I suppose this will be automatically fixed when the element ignores the click event)

Tried Safari and Chrome browsers and worked the same on both. Tried to play a little with the CSS and JS but couldn’t find a quick fix.

Although when hovering the buttons with the mouse it shows the tooltip and the prohibited sign, it’s accepting my clicks on both the rename pencil and the trash button

Thanks for noticing this. This is because of the CSS update, which is very bad. I undid this and wrapped the disabled icons in a parent and added tooltips to the parent.

if I click "reload" having the #Upload string on the URL, the Upload pane does show. (I suppose this will be automatically fixed when the element ignores the click event)

I tried to disable and add tooltips to the file chooser button in the Upload tab, but couldn't get it working. However, I think the point of the Lock button is to warn the user that changing files results in changing the portable data hash, not actually about any data integrity issues on server. Hence, I think this is a corner case that we can ignore.

Thanks.

• When locked, the tooltip works fine on Chrome, but not (at least for me) on Safari. Tried changing the <span> to <div> and got it working on both browsers, but floating elements kind of problems appeared. OTOH, on Safari the rename tooltip works fine when hovering on the file’s name, but not when hovering over the pencil icon. Don’t know if this issue is worth any more time investment.
• When unlocked, the tooltip on the trash button says “Remove <file_path>” If this path is long, the tooltip’s width is not enough to show the entire text, maybe it’s better to change the tooltip to “Remove this file”?
• Other than that, LGTM.

When locked, the tooltip works fine on Chrome, but not (at least for me) on Safari ...

I can't test in Safari in my VM, but things worked fine in Chrome and Firefox. I will test with Safari after merging (in staging) and see if anything else needs to be done

When unlocked, the tooltip on the trash button says “Remove <file_path>” If this path is long, the tooltip’s width is not enough to show the entire text, maybe it’s better to change the tooltip to “Remove this file”?

Updated as such

I also noticed that the disabled tooltips were not working correctly for image type files and corrected this bug.

Thanks.

LGTM, thanks!