Project

General

Profile

Actions
Copy link

Idea #11710

closed

[Workbench][Performance] container / container_request show page taking too long to load

Added by Radhika Chippada almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
2017-05-24 sprint
Story points:
-

Description

Loading of the pages /containers/qr1hi-dz642-uypqs2exiy7so7l and /container_requests/qr1hi-xvhdp-6490dha4xorrfwz takes more than 60s each.

A couple observations:

  • Each container_uuid of each child is being fetched in a separate request
  • cputime computation is taking a long time as all descendants are being fetched one at a time

Subtasks 1 (0 open — 1 closed)

Task #11727: Review branch 11710-container-request-show-perfResolvedRadhika Chippada05/18/2017Actions

Related issues

Related to Arvados - Idea #11580: [Workbench] Improve format of /container_requests index pageResolvedRadhika Chippada05/16/2017Actions
Actions
Copy link
 #1

Updated by Radhika Chippada almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Radhika Chippada almost 7 years ago

  • Subject changed from [Workbench][Performance] container / container_request show page takes too long to load due to fetching of each associated container in a separate request to [Workbench][Performance] container / container_request show page taking too long to load
  • Description updated (diff)
Actions
Copy link
 #3

Updated by Radhika Chippada almost 7 years ago

  • Status changed from New to In Progress
  • Assigned To set to Radhika Chippada
  • Target version set to 2017-05-24 sprint
Actions
Copy link
 #4

Updated by Radhika Chippada almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #5

Updated by Radhika Chippada almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #6

Updated by Lucas Di Pentima almost 7 years ago

Just a couple of small comments:

  • File apps/workbench/app/models/container_work_unit.rb
    • Could lines 24 & 26 be unified by using an ‘||’ operator?
      **Line 32: Typo detected on cr.request_container_uuid (also make workbench_units tests fail)

Apart from those, lgtm.

Actions
Copy link
 #7

Updated by Radhika Chippada almost 7 years ago

@ d7e956d1ed2ffeb5b585896e6568481d474bb095

Could lines 24 & 26 be unified by using an ‘||’ operator?

Yes, I cleaned up this and some more

Line 32: Typo detected on cr.request_container_uuid (also make workbench_units tests fail)

Gee thanks for catching this. I corrected this and started tests @ https://ci.curoverse.com/job/developer-run-tests/292/

Actions
Copy link
 #8

Updated by Radhika Chippada almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:49a9c33ea6119c42ad3d2d585ed7b2f9e4339132.

Actions
Copy link

Also available in: Atom PDF