Project

General

Profile

Actions
Copy link

Bug #11718

closed

Update crunch-run for docker client lib update

Added by Peter Amstutz almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
-
Category:
-
Target version:
2017-05-24 sprint
Story points:
-

Description

The function signature for Docker.ContainerWait has changed, this is breaking crunch-run.

In addition, github.com/docker/docker now redirects to github.com/moby/moby

Actions
Copy link
 #1

Updated by Peter Amstutz almost 7 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Lucas Di Pentima almost 7 years ago

Reviewed 9d33e0c4f
Jenkins tests ran ok: https://ci.curoverse.com/job/developer-run-tests/288/

There's no reference to github.com/moby/moby imports, and on docker's documentation it seems that it isn't updated yet, I suppose the redirect will be kept for a long time.

LGTM.

Actions
Copy link
 #3

Updated by Peter Amstutz almost 7 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:f0e917d2305c66cb7120125aaf6592ce2b9e3855.

Actions
Copy link

Also available in: Atom PDF