Bug #11821

[API Server] Update discovery document to include latest API updates

Added by Tom Morris over 4 years ago. Updated over 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Start date:
06/07/2017
Due date:
% Done:

0%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description

Two new calls are missing:
- include trash
- recursive listing of group contents


Subtasks

Task #11831: Review branch 11821-discovery-doc-updatesResolvedRadhika Chippada


Related issues

Related to Arvados - Bug #11652: [Workbench] Search should search subprojects as well as selected projectResolved05/10/2017

Related to Arvados - Story #9587: [Workbench] Interface to list and untrash trashed collectionsResolved07/12/2016

Has duplicate Arvados - Bug #11822: [API] Add recursive and include_trash params missing from discovery docDuplicate

Associated revisions

Revision d66b42e1
Added by Radhika Chippada over 4 years ago

closes #11821
Merge branch '11821-discovery-doc-updates'

History

#1 Updated by Radhika Chippada over 4 years ago

  • Assigned To set to Radhika Chippada

#2 Updated by Tom Clegg over 4 years ago

These need to be added to Colection._index_requires_parameters etc. (see source:services/api/app/controllers/arvados/v1/groups_controller.rb)

#3 Updated by Radhika Chippada over 4 years ago

  • Status changed from New to In Progress

#4 Updated by Radhika Chippada over 4 years ago

Branch 11821-discovery-doc-updates is ready for review @ cac20b7dd2177edebc0a4f8087032d1143bd524e

Test run @ https://ci.curoverse.com/job/developer-run-tests/323/

#6 Updated by Radhika Chippada over 4 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:d66b42e150030edff5ddb211d76d03d4bcd572ec.

#7 Updated by Radhika Chippada over 4 years ago

  • Status changed from Resolved to In Progress

The arv command seems to send include_trash = "false" sometimes. This will be misinterpreted as include_trash != nil. Updated to check for bogus values @ 82c90381c1ebdab5be7870b13ca8898e81b042c8

#8 Updated by Lucas Di Pentima over 4 years ago

Ran services/api local tests successfully.
LGTM, thanks!

#9 Updated by Radhika Chippada over 4 years ago

  • Status changed from In Progress to Resolved

I have not seen this issue after my initial observation and logic exists in application_controller to treat "false" as false. So, I am going to discard this update and leave it as in cac20b7dd2177edebc0a4f8087032d1143bd524e.

Also available in: Atom PDF