Bug #11821: [API Server] Update discovery document to include latest API updates - Arvados

Custom queries

All assigned issues
All issues assigned for grooming
My issues for grooming
My issues for grooming (no story pts)
Prioritized open issues

Actions

Copy link

Bug #11821

closed

[API Server] Update discovery document to include latest API updates

Added by Tom Morris almost 7 years ago. Updated almost 7 years ago.

Status:

Resolved

Priority:

Normal

Assigned To:

Radhika Chippada

Category:

Target version:

2017-06-21 sprint

Story points:

Description

Two new calls are missing:
- include trash
- recursive listing of group contents

Subtasks 1 (0 open — 1 closed)

Task #11831: Review branch 11821-discovery-doc-updates

Resolved

Radhika Chippada

06/07/2017

Actions

Related issues

Related to Arvados - Bug #11652: [Workbench] Search should search subprojects as well as selected project	Resolved	Radhika Chippada	05/10/2017	Actions
Related to Arvados - Idea #9587: [Workbench] Interface to list and untrash trashed collections	Resolved	Radhika Chippada	07/12/2016	Actions
Has duplicate Arvados - Bug #11822: [API] Add recursive and include_trash params missing from discovery doc	Duplicate			Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Assigned To set to Radhika Chippada

Actions

Copy link

Updated by Tom Clegg almost 7 years ago

These need to be added to Colection._index_requires_parameters etc. (see source:services/api/app/controllers/arvados/v1/groups_controller.rb)

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Status changed from New to In Progress

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Branch 11821-discovery-doc-updates is ready for review @ cac20b7dd2177edebc0a4f8087032d1143bd524e

Test run @ https://ci.curoverse.com/job/developer-run-tests/323/

Actions

Copy link

Updated by Lucas Di Pentima almost 7 years ago

Updates at cac20b7dd2177edebc0a4f8087032d1143bd524e LGTM, thanks.

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Status changed from In Progress to Resolved

Applied in changeset arvados|commit:d66b42e150030edff5ddb211d76d03d4bcd572ec.

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Status changed from Resolved to In Progress

The arv command seems to send include_trash = "false" sometimes. This will be misinterpreted as include_trash != nil. Updated to check for bogus values @ 82c90381c1ebdab5be7870b13ca8898e81b042c8

Actions

Copy link

Updated by Lucas Di Pentima almost 7 years ago

Ran services/api local tests successfully.
LGTM, thanks!

Actions

Copy link

Updated by Radhika Chippada almost 7 years ago

Status changed from In Progress to Resolved

I have not seen this issue after my initial observation and logic exists in application_controller to treat "false" as false. So, I am going to discard this update and leave it as in cac20b7dd2177edebc0a4f8087032d1143bd524e.

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

Arvados

Custom queries

Bug #11821

[API Server] Update discovery document to include latest API updates

Updated by Radhika Chippada almost 7 years ago

Updated by Tom Clegg almost 7 years ago

Updated by Radhika Chippada almost 7 years ago

Updated by Radhika Chippada almost 7 years ago

Updated by Lucas Di Pentima almost 7 years ago

Updated by Radhika Chippada almost 7 years ago

Updated by Radhika Chippada almost 7 years ago

Updated by Lucas Di Pentima almost 7 years ago

Updated by Radhika Chippada almost 7 years ago