Project

General

Profile

Actions

Idea #11870

closed

[Workbench] We have two pages /repositories, and /users/<uuid>/repositories. Move the functionality from /users/<uuid>/repositories page into /repositories and remove it.

Added by Radhika Chippada almost 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
Story points:
-

Subtasks 1 (0 open1 closed)

Task #11880: Review 11870-repositories-indexResolvedRadhika Chippada06/30/2017Actions
Actions #1

Updated by Radhika Chippada almost 7 years ago

In addition, add paging or infinite scrolling to the page.

Actions #2

Updated by Tom Morris almost 7 years ago

  • Target version set to 2017-07-05 sprint
Actions #3

Updated by Radhika Chippada almost 7 years ago

  • Assigned To set to Radhika Chippada
Actions #4

Updated by Radhika Chippada almost 7 years ago

  • Status changed from New to In Progress
Actions #5

Updated by Radhika Chippada over 6 years ago

Branch 11870-repositories-index

  • /repositories page is improved to show URL column and display order (owned first and then the rest, sorted by name) as does the user menu repositories page. Also, added infinite scrolling.
  • User menu repositories link now links to /repositories. Removed / moved the associated code
Actions #6

Updated by Lucas Di Pentima over 6 years ago

Reviewing d898b4cb9

  • File apps/workbench/app/controllers/repositories_controller.rb
    • Lines 37, 38: Those conditionals assignments could be simplified by using andand.
  • File apps/workbench/app/views/repositories/_show_help.html.erb
    • Line 3: Shouldn’t the limit(1) be after the filter()?
    • Lines 3 & 4 could be simplified by using ||
  • Jenkins tests have failed
Actions #7

Updated by Radhika Chippada over 6 years ago

Thanks.

Actions #8

Updated by Lucas Di Pentima over 6 years ago

LGTM, thanks!

Actions #9

Updated by Radhika Chippada over 6 years ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:019c7c67a37cd2a6e43ceed73771c1cd87c5f615.

Actions

Also available in: Atom PDF