Actions
Bug #11896
closed
[Node-Manager] self.disk == None causes to raise an exception
Story points:
-
Description
2017-06-22_17:09:49.21057 2017-06-22 17:09:49 root[12054] ERROR: Uncaught exception during setup
2017-06-22_17:09:49.21078 Traceback (most recent call last):
2017-06-22_17:09:49.21082 File "/usr/lib/python2.7/dist-packages/arvnodeman/launcher.py", line 128, in main
2017-06-22_17:09:49.21085 server_calculator = build_server_calculator(config)
2017-06-22_17:09:49.21088 File "/usr/lib/python2.7/dist-packages/arvnodeman/launcher.py", line 77, in build_server_calculator
2017-06-22_17:09:49.21092 config.getfloat('Daemon', 'node_mem_scaling'))
2017-06-22_17:09:49.21095 File "/usr/lib/python2.7/dist-packages/arvnodeman/jobqueue.py", line 51, in __init__
2017-06-22_17:09:49.21098 for s, kws in server_list]
2017-06-22_17:09:49.21101 File "/usr/lib/python2.7/dist-packages/arvnodeman/jobqueue.py", line 30, in __init__
2017-06-22_17:09:49.21110 self.scratch = self.disk * 1000
2017-06-22_17:09:49.21113 TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'
Updated by Nico César almost 7 years ago
I monkeypatched this way:
if self.disk == None:
self.scratch = None
else:
self.scratch = self.disk * 1000
and at least the manager came up ...
Updated by Peter Amstutz almost 7 years ago
- Project changed from 40 to Arvados
- Status changed from New to In Progress
- Target version set to 2017-07-05 sprint
Updated by Lucas Di Pentima almost 7 years ago
LGTM. Just a detail: there's some commented code left behind at services/nodemanager/tests/integration_test.py:L30
Updated by Peter Amstutz almost 7 years ago
- Status changed from In Progress to Resolved
- % Done changed from 0 to 100
Applied in changeset arvados|commit:ecc8ee4e5edabaf7d888f55a99184b1efe4a9060.
Actions