Project

General

Profile

Actions

Bug #11910

closed

[arvados-ws] Fix racy test case

Added by Tom Clegg almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Tests
Target version:
-
Story points:
-

Description

From https://ci.curoverse.com/job/developer-run-tests-remainder/366/console

FAIL: session_v0_test.go:146: v0Suite.TestSubscribe

session_v0_test.go:167:
    c.Check(lg.ObjectUUID, check.Equals, uuid)
... obtained string = "zzzzz-7fd4e-90gj05dqzlgwrk4" 
... expected string = "zzzzz-7fd4e-dpp8ugz03ma4bee" 

session_v0_test.go:168:
    c.Check(lg.EventType, check.Equals, etype)
... obtained string = "update" 
... expected string = "create" 

session_v0_test.go:168:
    c.Check(lg.EventType, check.Equals, etype)
... obtained string = "create" 
... expected string = "blip" 

session_v0_test.go:168:
    c.Check(lg.EventType, check.Equals, etype)
... obtained string = "blip" 
... expected string = "update" 

(I've seen this once recently on my dev box too.)

Actions #1

Updated by Tom Clegg almost 7 years ago

  • Description updated (diff)
  • Category set to Tests
Actions #2

Updated by Tom Clegg almost 7 years ago

  • Status changed from New to In Progress
  • Assigned To set to Tom Clegg
Actions #3

Updated by Tom Clegg almost 7 years ago

The test failures are exposing a real race bug. I didn't see a quick way to fix it, so in the meantime this avoids hitting the bug in the test case.

11910-ws-test-race @ 738c46babb430153b2e931ed0dd2ca0c34478579

Actions #4

Updated by Tom Clegg almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:3fe48e9f9ce4f29ececb07fa8934565992a8d52f.

Actions

Also available in: Atom PDF