Bug #11927

[Workbench] test_Report_network_error failure

Added by Peter Amstutz 19 days ago. Updated 18 days ago.

Status:ResolvedStart date:
Priority:NormalDue date:
Assignee:Tom Clegg% Done:

0%

Category:Tests
Target version:2017-07-19 sprint
Story points-
Velocity based estimate-

Associated revisions

Revision 446d2d89
Added by Tom Clegg 19 days ago

Merge branch '11927-tags-test'

refs #11927

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz 19 days ago

  • Description updated (diff)

#2 Updated by Tom Clegg 19 days ago

Probably this:

commit e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353
Author: Tom Clegg <tom@curoverse.com>
Date:   Fri Jun 30 15:34:08 2017 -0400

    8784: Fix test for latest firefox.

    Given "http://host:99999/path", Firefox 54 returns an error
    "SyntaxError: The URI is malformed" instead of trying to connect to
    port 99999 and returning a network error. Changing 99999 to 0 produces
    the try-and-fail behavior we want to test.

    Arvados-DCO-1.1-Signed-off-by: Tom Clegg <tom@curoverse.com>

diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb
index 552a9cd..f2a638f 100644
--- a/apps/workbench/test/integration/collection_upload_test.rb
+++ b/apps/workbench/test/integration/collection_upload_test.rb
@@ -92,11 +92,11 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest
   test "Report network error" do
     need_selenium "to make file uploads work" 
     use_token :admin do
-      # Even if you somehow do port>2^16, surely nx.example.net won't
+      # Even if port 0 is a thing, surely nx.example.net won't
       # respond
       KeepService.where(service_type: 'proxy').first.
         update_attributes(service_host: 'nx.example.net',
-                          service_port: 99999)
+                          service_port: 0)
     end
     visit page_with_token 'active', sandbox_path

#3 Updated by Tom Clegg 19 days ago

  • Status changed from New to In Progress
  • Assignee set to Tom Clegg

#5 Updated by Tom Clegg 19 days ago

This test passed (yay)

CollectionUploadTest#test_Report_network_error = 8.58 s = .

but a different test failed

  4) Error:
CollectionsTest#test_collection_tags_tab:
Capybara::ExpectationNotMet: expected not to find text "key 2" in "workbench:test Dashboard Projects Home Trash owned_by_active (No description provided) Collection UUID: Content address: Content size: 1 file totalling 3 bytes This collection was the output of the following: Sharing and permissions Your API token is not authorized to manage collection sharing links. Copy to project... Move collection... Files Upload Tags Provenance graph Used by Advanced Edit Key Value key 2 value 2" 
    test/integration/collections_test.rb:512:in `block in <class:CollectionsTest>'
    test/test_helper.rb:303:in `run'

#7 Updated by Tom Clegg 19 days ago

  • Category set to Tests
  • Status changed from In Progress to Resolved

Also available in: Atom PDF