[Workbench] test_Report_network_error failure
#2 Updated by Tom Clegg over 4 years ago
commit e59c1d365d9b6e1eff9b5cb030a8b1a3aaf14353 Author: Tom Clegg <email@example.com> Date: Fri Jun 30 15:34:08 2017 -0400 8784: Fix test for latest firefox. Given "http://host:99999/path", Firefox 54 returns an error "SyntaxError: The URI is malformed" instead of trying to connect to port 99999 and returning a network error. Changing 99999 to 0 produces the try-and-fail behavior we want to test. Arvados-DCO-1.1-Signed-off-by: Tom Clegg <firstname.lastname@example.org> diff --git a/apps/workbench/test/integration/collection_upload_test.rb b/apps/workbench/test/integration/collection_upload_test.rb index 552a9cd..f2a638f 100644 --- a/apps/workbench/test/integration/collection_upload_test.rb +++ b/apps/workbench/test/integration/collection_upload_test.rb @@ -92,11 +92,11 @@ class CollectionUploadTest < ActionDispatch::IntegrationTest test "Report network error" do need_selenium "to make file uploads work" use_token :admin do - # Even if you somehow do port>2^16, surely nx.example.net won't + # Even if port 0 is a thing, surely nx.example.net won't # respond KeepService.where(service_type: 'proxy').first. update_attributes(service_host: 'nx.example.net', - service_port: 99999) + service_port: 0) end visit page_with_token 'active', sandbox_path
#4 Updated by Nico César over 4 years ago
updated the stuff and kicked https://ci.curoverse.com/job/run-tests-apps-workbench-integration/1084/console which FAILED
#5 Updated by Tom Clegg over 4 years ago
This test passed (yay)
CollectionUploadTest#test_Report_network_error = 8.58 s = .
but a different test failed
4) Error: CollectionsTest#test_collection_tags_tab: Capybara::ExpectationNotMet: expected not to find text "key 2" in "workbench:test Dashboard Projects Home Trash owned_by_active (No description provided) Collection UUID: Content address: Content size: 1 file totalling 3 bytes This collection was the output of the following: Sharing and permissions Your API token is not authorized to manage collection sharing links. Copy to project... Move collection... Files Upload Tags Provenance graph Used by Advanced Edit Key Value key 2 value 2" test/integration/collections_test.rb:512:in `block in <class:CollectionsTest>' test/test_helper.rb:303:in `run'