Project

General

Profile

Actions
Copy link

Idea #11995

closed

[Workbench] Support more filetypes for in-browser display

Added by Tom Morris almost 7 years ago. Updated almost 7 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Radhika Chippada
Category:
-
Target version:
2017-08-02 sprint
Start date:
07/19/2017
Due date:
Story points:
0.5

Description

We should offer the option for in-browser display for more filetypes including: .cwl, .yaml, .csv, .tsv, .vcf, and .bed.

Some of these can be large, but the user can click the Back button and abort the display if they accidentally start downloading a file which is too big.

Subtasks 1 (0 open — 1 closed)

Task #11998: Review branch 11995-collecion-filetypesResolvedRadhika Chippada07/19/2017Actions
Actions
Copy link
 #1

Updated by Radhika Chippada almost 7 years ago

  • Description updated (diff)
  • Assigned To set to Radhika Chippada
Actions
Copy link
 #2

Updated by Radhika Chippada almost 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #3

Updated by Radhika Chippada almost 7 years ago

  • Story points changed from 1.0 to 0.5

Branch 11995-collecion-filetypes @ be0830dcdc10ff352d89a20fa2a24000a5ca8984

  • The file types .yaml, .csv, .tsv, .vcf can already be previewed. The preview of these files behaves as browser supports it. That is: in Chrome this is doing a download and in Firefox the file is displayed
  • Added .bed and .cwl to supported preview enabled file types
  • The file type .cwl is not in ruby MIME::Types and I added special handling to enable preview for this. However, this may not be a known mime type to the browser and hence how the preview works depends on the browser. In Chrome, the file is downloaded. In Firefox, I get a dialog asking to save the file.

Test run @ https://ci.curoverse.com/job/developer-run-tests/388/

Actions
Copy link
 #4

Updated by Lucas Di Pentima almost 7 years ago

Just one comment:

  • For the .cwl extension, it only works when it’s in lower case. I tried renaming a *.bed to *.BED and *.csv to *.CSV and it works ok, but it doesn’t with .CWL files, for example (that is, the preview button isn't clickable).
Actions
Copy link
 #5

Updated by Tom Clegg almost 7 years ago

Including ?disposition=inline in keep-web URIs causes keep-web to generate a Content-Disposition header in the response. This might be enough to force Chrome to display inline content for Preview, regardless of MIME type.

Actions
Copy link
 #6

Updated by Radhika Chippada almost 7 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:0b51ce6bfc3c50155de18eb4440021688462fb6a.

Actions
Copy link

Also available in: Atom PDF