Bug #12026

[crunchstat-summary] gives invalid min_cores recommendation

Added by Tom Morris about 2 years ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
07/24/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-
Release relationship:
Auto

Description

This recommendation doesn't make sense from a couple of points of view:

### Summary for cwl-runner (su92l-8i9sb-ll9w11siojvlro6)
category        metric  task_max        task_max_rate   job_total
cpu     cpus    1       -       -
# Max CPU time spent by a single task: 1045.15s
# Max CPU usage in a single interval: 99.80%
# Overall CPU usage: 18.81%
#!! cwl-runner su92l-8i9sb-ll9w11siojvlro6 max CPU usage was 100% -- try runtime_constraints "min_cores_per_node":1

It shouldn't recommend a "change" to the same value as is current and it shouldn't recommend a change for max cpu < 100%


Subtasks

Task #14956: Review 14451-crunchstat-summary-cache-ramResolvedTom Morris

Associated revisions

Revision b8a3b3f1 (diff)
Added by Tom Morris 5 months ago

Use default of 1 if no cores requested. refs #12026

Arvados-DCO-1.1-Signed-off-by: Tom Morris <>

Revision 46cec9d4 (diff)
Added by Tom Morris 5 months ago

Use default of 1 if no cores requested. refs #12026

Arvados-DCO-1.1-Signed-off-by: Tom Morris <>

Revision 4dd55960 (diff)
Added by Tom Morris 5 months ago

Use default of 1 if no cores requested. refs #12026

Arvados-DCO-1.1-Signed-off-by: Tom Morris <>

Revision d23f9c8a
Added by Tom Morris 5 months ago

Merge branch '14451-crunchstat-summary-cache-ram'

Fix three small crunchstat-summary issues:
- Use default of 1 if no cores requested. fixes #12026
- Don't recommend RAM or CPU changes based on zero usage. fixes #10570
- Remove extra MB (2**20) factor in Keep cache recommendation. Fixes #14451

Arvados-DCO-1.1-Signed-off-by: Tom Morris <>

History

#1 Updated by Tom Morris over 1 year ago

  • Subject changed from crunchstat-summary gives invalid min_cores recommendation to [crunchstat-summary] gives invalid min_cores recommendation
  • Description updated (diff)

#2 Updated by Tom Morris over 1 year ago

I think the problem here was triggered by the fact that there was no cores run-time constraint specified. The job got scheduled on a single core machine (which seems like the right default), but crunchstat-summary contains this code:

        used_cores = max(1, int(math.ceil(cpu_max_rate)))
        asked_cores = self.existing_constraints.get(constraint_key)
        if asked_cores is None or used_cores < asked_cores:
        yield (
                '#!! {} max CPU usage was {}% -- '
                'try runtime_constraints "{}":{}'

I think perhaps asked_cores should have a default value of 1 if it isn't specified.

#3 Updated by Tom Morris 5 months ago

  • Target version changed from Arvados Future Sprints to 2019-03-27 Sprint

#4 Updated by Tom Morris 5 months ago

  • Assigned To set to Tom Morris

#5 Updated by Tom Morris 5 months ago

  • Status changed from New to In Progress

#6 Updated by Tom Morris 5 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#7 Updated by Tom Morris 3 months ago

  • Release set to 15

Also available in: Atom PDF