Arvados

LGTM.

A more general comment: The test suite seems heavy on the copy-paste. Why do all these test cases have "except: logging.exception("")"? Hopefully it isn't considered normal for these blocks to fail in lots of different ways -- could we specify the exception(s) we're expecting due to the test environment?

Tom Clegg wrote:

LGTM.

A more general comment: The test suite seems heavy on the copy-paste. Why do all these test cases have "except: logging.exception("")"? Hopefully it isn't considered normal for these blocks to fail in lots of different ways -- could we specify the exception(s) we're expecting due to the test environment?

I don't have a good explanation for the try/except blocks. The best I can think of is that at one point it was failing for some reason, but I wanted to see the result of the assert_called_with checks to know what was actually wrong.

I agree there is a number of tests in that file could be cleaned up a bit and put into a framework. (I'll keep that in mind for next time I touch this).