Bug #12186

[cwl] cwl.input.yml contains "nameroot" and "nameext" fields, breaks reuse with RunInSingleContainer

Added by Peter Amstutz 9 months ago. Updated 7 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/12/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Subtasks

Task #12188: Review 12186-cwl-no-namerootResolvedPeter Amstutz

Associated revisions

Revision 194df852
Added by Peter Amstutz 8 months ago

Merge branch '12186-cwl-no-nameroot' closes #12186

Arvados-DCO-1.1-Signed-off-by: Peter Amstutz <>

History

#1 Updated by Peter Amstutz 9 months ago

  • Status changed from New to In Progress
  • Assigned To set to Peter Amstutz

#2 Updated by Peter Amstutz 9 months ago

  • Target version changed from 2017-08-30 Sprint to 2017-09-13 Sprint

#4 Updated by Lucas Di Pentima 8 months ago

As far as I can tell, this looks good to me. One question: would it be too complex to make a test to prove that reuse is working with RunInSingleContainer? This would detect potential similar problems in the future.

#5 Updated by Peter Amstutz 8 months ago

Lucas Di Pentima wrote:

As far as I can tell, this looks good to me. One question: would it be too complex to make a test to prove that reuse is working with RunInSingleContainer? This would detect potential similar problems in the future.

I did this is 45054326217ef62eeef9bcdbd0ed429c55650609 I added a File input called "fileblub", and updated TestWorkflow.test_run to check that the intermediate input.cwl.json has only the expected fields for File objects.

#6 Updated by Peter Amstutz 8 months ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:194df852b504214879c005a0b730ab1e00395160.

#7 Updated by Tom Morris 7 months ago

From a customer point of view, it's important for them to be able to know which jobs are potentially affected by this issue.

Do we know the range of versions and/or dates that are affected?

Also available in: Atom PDF