Story #12197

Add PDH column and filter to trash display

Added by Tom Morris 25 days ago. Updated 6 days ago.

Status:ResolvedStart date:08/30/2017
Priority:NormalDue date:
Assignee:Tom Clegg% Done:

100%

Category:-
Target version:2017-09-27 Sprint
Story points-Remaining (hours)0.00 hour
Velocity based estimate-

12197-search-pdh.png (104 KB) Tom Clegg, 09/13/2017 09:00 pm

12197-search-pdh-0923.png (69 KB) Tom Clegg, 09/18/2017 01:29 pm


Subtasks

Task #12202: Review 12197-show-pdh-in-trashResolvedTom Clegg

Associated revisions

Revision a6d5c9b5
Added by Tom Clegg 6 days ago

Merge branch '12197-show-pdh-in-trash'

closes #12197

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Tom Morris 25 days ago

  • Assignee set to Tom Clegg

#2 Updated by Tom Clegg 16 days ago

Confirmed the "filter by PDH" part already works. It's inconvenient to test, and not obvious that it's working, just because the PDH isn't shown.

#3 Updated by Tom Morris 16 days ago

As we discussed during grooming, let's go with the approach of stacking the two dates to free up space for the PDH. I think it'd be useful to include the UUID as well (although it's often there for collections which don't have names).

So, the columns become:

Name, Date Trashed / To Be Deleted, Owner, UUID / PDH, Files

where the two columns with slashes have the two different types of contents stacked vertically in the same column.

#4 Updated by Tom Clegg 11 days ago

Haven't updated tests yet.

How does this look?

12197-show-pdh-in-trash @ 6ac4615d13060a19d8cafbe35b67838e8ead33b0

https://12197.tom.shell.9tee4.arvadosapi.com/trash

#5 Updated by Tom Morris 10 days ago

Looks pretty good. Let's get rid of the trash: and delete: labels since they just make the alignment even more raggedy.

I'm of two minds about the date/times. On the one hand I like respecting the user's locale, but on the other having the leading (left-hand) pieces be variable length makes vertical alignment problematic. The example data is best case, but

1:00 PM
12:00 PM

throws the alignment off.

I think I'm inclined to call it good enough with the deletion of the labels.

#6 Updated by Tom Clegg 10 days ago

  • Target version changed from 2017-09-13 Sprint to 2017-09-27 Sprint

#7 Updated by Tom Clegg 10 days ago

  • Status changed from New to In Progress

#9 Updated by Tom Clegg 6 days ago

#10 Updated by Lucas Di Pentima 6 days ago

A couple of minor comments:

  • File apps/workbench/app/views/trash_items/_show_recent_trash.html.erb
    • Line 47: For UI consistency’s sake, should the PDH acronym be included on the column header? Also I’m seeing that we use the phrase “Content address” for the PDH field on the collection view page, do you think something like “PDH (Content address)” would be a good header alternative?
  • File apps/workbench/app/views/trash_items/_show_trash_rows.html.erb
    • Line 28: Would it be convenient to check for object type before asking for the pdh and only showing it when it’s a collection? I’m thinking about the soon to be added projects to the trash feature.

#11 Updated by Tom Clegg 6 days ago

Lucas Di Pentima wrote:

something like “PDH (Content address)” would be a good header alternative?

Sure, went with "Content address (PDH)"

Would it be convenient to check for object type before asking for the pdh and only showing it when it’s a collection? I’m thinking about the soon to be added projects to the trash feature.

I think we should stick to the issue at hand, and leave the future stuff for a future branch. Otherwise: the next column has "files" with the same problem, the alternate case wouldn't be testable, etc.

#12 Updated by Anonymous 6 days ago

  • Status changed from In Progress to Resolved

Applied in changeset arvados|commit:a6d5c9b5a512e7c4b04e7f73fe2777bd81277602.

Also available in: Atom PDF