Arvados

Confirmed the "filter by PDH" part already works. It's inconvenient to test, and not obvious that it's working, just because the PDH isn't shown.

As we discussed during grooming, let's go with the approach of stacking the two dates to free up space for the PDH. I think it'd be useful to include the UUID as well (although it's often there for collections which don't have names).

So, the columns become:

Name, Date Trashed / To Be Deleted, Owner, UUID / PDH, Files

where the two columns with slashes have the two different types of contents stacked vertically in the same column.

Looks pretty good. Let's get rid of the trash: and delete: labels since they just make the alignment even more raggedy.

I'm of two minds about the date/times. On the one hand I like respecting the user's locale, but on the other having the leading (left-hand) pieces be variable length makes vertical alignment problematic. The example data is best case, but

1:00 PM
12:00 PM

throws the alignment off.

I think I'm inclined to call it good enough with the deletion of the labels.

12197-show-pdh-in-trash @ 0923fecbf907d2aaa7f35775eba9ecd947eed098

https://ci.curoverse.com/job/developer-run-tests/456/

A couple of minor comments:

• File apps/workbench/app/views/trash_items/_show_recent_trash.html.erb
  • Line 47: For UI consistency’s sake, should the PDH acronym be included on the column header? Also I’m seeing that we use the phrase “Content address” for the PDH field on the collection view page, do you think something like “PDH (Content address)” would be a good header alternative?
• File apps/workbench/app/views/trash_items/_show_trash_rows.html.erb
  • Line 28: Would it be convenient to check for object type before asking for the pdh and only showing it when it’s a collection? I’m thinking about the soon to be added projects to the trash feature.

Lucas Di Pentima wrote:

something like “PDH (Content address)” would be a good header alternative?

Sure, went with "Content address (PDH)"

Would it be convenient to check for object type before asking for the pdh and only showing it when it’s a collection? I’m thinking about the soon to be added projects to the trash feature.

I think we should stick to the issue at hand, and leave the future stuff for a future branch. Otherwise: the next column has "files" with the same problem, the alternate case wouldn't be testable, etc.