Bug #12273

[crunch] Should not try to upload special files

Added by Peter Amstutz about 4 years ago. Updated about 4 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
Crunch
Target version:
Start date:
09/28/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

If the output directory contains special files (such as named pipes) they should be ignored by the uploader. Verify this is correct for both crunchrunner and crunch-run.

The only files which should be uploaded are regular files and symlinks.

Check and fix in both crunchrunner (crunch1) and crunchrun (crunch2)


Subtasks

Task #12361: Review 12273-skip-special-filesResolvedTom Clegg


Related issues

Related to Arvados - Bug #12183: [crunch-run] Handle symlinks with absolute paths into output directoryResolved09/28/2017

Associated revisions

Revision 9e58fc08
Added by Tom Clegg about 4 years ago

Merge branch '12273-skip-special-files'

closes #12273

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Peter Amstutz about 4 years ago

  • Subject changed from [crunchrunner] Should not try to upload named pipes to [crunch] Should not try to upload special files
  • Description updated (diff)

#2 Updated by Tom Morris about 4 years ago

  • Target version set to 2017-10-11 Sprint

#3 Updated by Tom Morris about 4 years ago

  • Description updated (diff)
  • Story points set to 1.0

#4 Updated by Tom Clegg about 4 years ago

  • Category set to Crunch
  • Assigned To set to Tom Clegg

#5 Updated by Tom Clegg about 4 years ago

  • Status changed from New to In Progress

#6 Updated by Tom Clegg about 4 years ago

12273-skip-special-files @ 97aae1ab26418204078599a5ddbff493d26e32d8

Also fixed #11583 -- at least, fixed enough to pass crunch-run tests on a 4GB VM.

#7 Updated by Lucas Di Pentima about 4 years ago

This LGTM, please merge. Thanks!

#8 Updated by Anonymous about 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

Applied in changeset arvados|commit:9e58fc08fa949a6468626c001cd289f88e75fa15.

Also available in: Atom PDF