Feature #12315

[Workbench] on all processes page, add filter to make it possible to exclude sub workflows

Added by Ward Vandewege almost 3 years ago. Updated about 2 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
02/17/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0
Release relationship:
Auto

Subtasks

Task #13083: Review 12315-exclude-child-procsResolvedTom Clegg


Related issues

Related to Arvados - Feature #12517: [Workbench] page with a view of all the top level container requestsResolved10/31/2017

Associated revisions

Revision b17f04b7
Added by Tom Clegg over 2 years ago

Merge branch '12315-exclude-child-procs'

closes #12315

Arvados-DCO-1.1-Signed-off-by: Tom Clegg <>

History

#1 Updated by Tom Morris over 2 years ago

  • Subject changed from [Workbench] on all processes page, add filter to make it possible to exclude sub workflows to [Workbench] on all processes page, add filter to make it possible to exclude sub workflows
  • Target version set to To Be Groomed

#2 Updated by Tom Morris over 2 years ago

  • Story points set to 1.0

Add a checkbox which when checked filters out subworkflows

#3 Updated by Tom Morris over 2 years ago

  • Target version changed from To Be Groomed to 2018-02-28 Sprint

#4 Updated by Peter Amstutz over 2 years ago

  • Assigned To set to Peter Amstutz

#5 Updated by Peter Amstutz over 2 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg

#6 Updated by Peter Amstutz over 2 years ago

The jQuery based filterable-query control only handles full text queries, extending it to handle additional types of filters seems somewhat awkward and basically wasted effort since we are trying to migrate workbench to client-side rendering using Mithril.

As an alternative, I recommend adapting/refactoring multi-site search to do multi-site query of running processes as well.

#8 Updated by Tom Clegg over 2 years ago

  • Status changed from New to In Progress

#9 Updated by Peter Amstutz over 2 years ago

Thanks. I'll see about adding a test.

I think my original assessment still stands: even after looking your code, I still feel that jQuery control is sufficiently non-obvious that it would have takes me an equal or greater amount of time and effort as compared to copying and modifying the mithril based search page to display work units.

#10 Updated by Peter Amstutz over 2 years ago

12315-exclude-child-procs @ 31e3106b0f4b5ec8cd7e251bc6827a64063c1b0c

Use a synthetic show_children query parameter, because naively filtering on requesting_container_uuid breaks pipeline and job queries.

Behavior when {show_children: true} is consistent with current all_processes page.

Behavior when show_children is false/nil is consistent with dashboard (filter on requesting_container_uuid=null, only show pipelines, no jobs).

Default behavior is not to show children.

Fixed/added testing.

Test https://ci.curoverse.com/job/developer-run-tests/615/

#12 Updated by Anonymous over 2 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100

#13 Updated by Tom Morris about 2 years ago

  • Release set to 17

Also available in: Atom PDF