Project

General

Profile

Actions

Feature #12315

closed

[Workbench] on all processes page, add filter to make it possible to exclude sub workflows

Added by Ward Vandewege about 7 years ago. Updated over 6 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Story points:
1.0
Release relationship:
Auto

Subtasks 1 (0 open1 closed)

Task #13083: Review 12315-exclude-child-procsResolvedTom Clegg02/17/2018Actions

Related issues

Related to Arvados - Feature #12517: [Workbench] page with a view of all the top level container requestsResolved10/31/2017Actions
Actions #1

Updated by Tom Morris about 7 years ago

  • Subject changed from [Workbench] on all processes page, add filter to make it possible to exclude sub workflows to [Workbench] on all processes page, add filter to make it possible to exclude sub workflows
  • Target version set to To Be Groomed
Actions #2

Updated by Tom Morris almost 7 years ago

  • Story points set to 1.0

Add a checkbox which when checked filters out subworkflows

Actions #3

Updated by Tom Morris almost 7 years ago

  • Target version changed from To Be Groomed to 2018-02-28 Sprint
Actions #4

Updated by Peter Amstutz almost 7 years ago

  • Assigned To set to Peter Amstutz
Actions #5

Updated by Peter Amstutz almost 7 years ago

  • Assigned To changed from Peter Amstutz to Tom Clegg
Actions #6

Updated by Peter Amstutz almost 7 years ago

The jQuery based filterable-query control only handles full text queries, extending it to handle additional types of filters seems somewhat awkward and basically wasted effort since we are trying to migrate workbench to client-side rendering using Mithril.

As an alternative, I recommend adapting/refactoring multi-site search to do multi-site query of running processes as well.

Actions #8

Updated by Tom Clegg almost 7 years ago

  • Status changed from New to In Progress
Actions #9

Updated by Peter Amstutz over 6 years ago

Thanks. I'll see about adding a test.

I think my original assessment still stands: even after looking your code, I still feel that jQuery control is sufficiently non-obvious that it would have takes me an equal or greater amount of time and effort as compared to copying and modifying the mithril based search page to display work units.

Actions #10

Updated by Peter Amstutz over 6 years ago

12315-exclude-child-procs @ 31e3106b0f4b5ec8cd7e251bc6827a64063c1b0c

Use a synthetic show_children query parameter, because naively filtering on requesting_container_uuid breaks pipeline and job queries.

Behavior when {show_children: true} is consistent with current all_processes page.

Behavior when show_children is false/nil is consistent with dashboard (filter on requesting_container_uuid=null, only show pipelines, no jobs).

Default behavior is not to show children.

Fixed/added testing.

Test https://ci.curoverse.com/job/developer-run-tests/615/

Actions #12

Updated by Anonymous over 6 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Tom Morris over 6 years ago

  • Release set to 17
Actions

Also available in: Atom PDF