Bug #12316

[Workbench] deletion of data collections destroying the provenance graph - rendering crashes

Added by Ward Vandewege over 3 years ago. Updated over 3 years ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
09/25/2017
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
-

Description


Subtasks

Task #12322: Review 12316-fix-provenance-graphResolvedWard Vandewege

Associated revisions

Revision 5098820f (diff)
Added by Ward Vandewege over 3 years ago

Do not blow up the provenance graph if a PDH used in the workflow no
longer exists.

refs #12316

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 3895b3ad (diff)
Added by Ward Vandewege over 3 years ago

Do not blow up the provenance graph if a PDH used in the workflow no
longer exists.

refs #12316

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

Revision 2c0b0226
Added by Ward Vandewege over 3 years ago

Merge branch '12316-fix-provenance-graph'

closes #12316

Arvados-DCO-1.1-Signed-off-by: Ward Vandewege <>

History

#1 Updated by Ward Vandewege over 3 years ago

  • Subject changed from [Workbench] deletion of data collections destroying the provenance graph - rendering crashes to [Workbench] deletion of data collections destroying the provenance graph - rendering crashes
  • Description updated (diff)

#2 Updated by Ward Vandewege over 3 years ago

I have a fix for this bug in branch 12316-fix-provenance-graph at 5098820fed0920a31dd87a12c4f027318d7a1bd6

#3 Updated by Ward Vandewege over 3 years ago

  • Assigned To set to Ward Vandewege

#4 Updated by Ward Vandewege over 3 years ago

  • Target version set to 2017-09-27 Sprint

#5 Updated by Ward Vandewege over 3 years ago

  • Status changed from New to In Progress

#6 Updated by Lucas Di Pentima over 3 years ago

This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.

#7 Updated by Ward Vandewege over 3 years ago

  • Status changed from In Progress to Resolved

Lucas Di Pentima wrote:

This LGTM. Just one idea: would it be nice to also notify the user that the collection is deleted to minimize the surprise effect? Maybe adding '(deleted)' to the graph node's name could be enough.

Done in 3895b3adf05dc6c8d7b66e6bdd42e576a03b1f09.

I've merged this, thanks!

#8 Updated by Tom Morris over 3 years ago

Thanks for the quick fix! 6 hours from report to fix and <12 hours to merge. Don't forget to prepare to demo at sprint review :-)

Point of clarification for those following along in the distant future -- PDHs never cease to exist. They might not be resolvable to a collection (or they might resolve to multiple collections), but they always exist (says pedantic Tom).

Also available in: Atom PDF