Idea #12414
closed
[API] Contents of trashed projects are actually deleted once delete_at is past
Description
Extend existing sweep process needs to be extended to recursively traverse project hierarchy and delete records from the database where owner_uuid is the project being deleted.
Updated by Peter Amstutz over 6 years ago
- Target version changed from Arvados Future Sprints to To Be Groomed
Updated by Tom Morris over 6 years ago
- Description updated (diff)
- Target version changed from To Be Groomed to Arvados Future Sprints
- Story points set to 1.0
Updated by Peter Amstutz over 6 years ago
- Description updated (diff)
- Target version changed from Arvados Future Sprints to To Be Groomed
Updated by Peter Amstutz over 6 years ago
- Target version changed from To Be Groomed to Arvados Future Sprints
Updated by Tom Morris about 6 years ago
- Target version changed from Arvados Future Sprints to 2018-04-11 Sprint
Updated by Lucas Di Pentima about 6 years ago
- Assigned To changed from Peter Amstutz to Lucas Di Pentima
Updated by Lucas Di Pentima about 6 years ago
- Status changed from New to In Progress
Updated by Lucas Di Pentima about 6 years ago
Updates at fea63ac82 - branch 12414-delete-trashed-project-contents
Test run: https://ci.curoverse.com/job/developer-run-tests/673/
Ready for review.
Updated by Peter Amstutz about 6 years ago
This looks good. I have two small suggestions:
- I think you can write "klass.columns.collect{|c| c.name}" as "klass.columns.collect(&:name)"
- Add a couple of checks to the test "delete projects and their contents in SweepTrashedObjects" that things which shouldn't be deleted, were not deleted.
Updated by Lucas Di Pentima about 6 years ago
Updates at 5f463235c
Test run: https://ci.curoverse.com/job/developer-run-tests/674/
Updated test to confirm that only the expected records are being deleted.
Updated by Peter Amstutz about 6 years ago
Lucas Di Pentima wrote:
Updates at 5f463235c
Test run: https://ci.curoverse.com/job/developer-run-tests/674/Updated test to confirm that only the expected records are being deleted.
This LGTM
Updated by Lucas Di Pentima about 6 years ago
- Status changed from In Progress to Resolved
Applied in changeset arvados|001a60dff02545c2d2476a437b1846c9ae633941.