Story #12414

[API] Contents of trashed projects are actually deleted once delete_at is past

Added by Peter Amstutz 9 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Normal
Assigned To:
Category:
-
Target version:
Start date:
04/02/2018
Due date:
% Done:

100%

Estimated time:
(Total: 0.00 h)
Story points:
1.0

Description

Extend existing sweep process needs to be extended to recursively traverse project hierarchy and delete records from the database where owner_uuid is the project being deleted.


Subtasks

Task #13284: Review 12414-delete-trashed-project-contentsResolvedPeter Amstutz

Associated revisions

Revision 001a60df
Added by Lucas Di Pentima 3 months ago

Merge branch '12414-delete-trashed-project-contents'
Closes #12414

Arvados-DCO-1.1-Signed-off-by: Lucas Di Pentima <>

History

#1 Updated by Peter Amstutz 8 months ago

  • Target version changed from Arvados Future Sprints to To Be Groomed

#2 Updated by Tom Morris 8 months ago

  • Description updated (diff)
  • Target version changed from To Be Groomed to Arvados Future Sprints
  • Story points set to 1.0

#3 Updated by Peter Amstutz 8 months ago

  • Description updated (diff)
  • Target version changed from Arvados Future Sprints to To Be Groomed

#4 Updated by Peter Amstutz 8 months ago

  • Target version changed from To Be Groomed to Arvados Future Sprints

#5 Updated by Tom Morris 3 months ago

  • Target version changed from Arvados Future Sprints to 2018-04-11 Sprint

#6 Updated by Peter Amstutz 3 months ago

  • Assigned To set to Peter Amstutz

#7 Updated by Lucas Di Pentima 3 months ago

  • Assigned To changed from Peter Amstutz to Lucas Di Pentima

#8 Updated by Lucas Di Pentima 3 months ago

  • Status changed from New to In Progress

#9 Updated by Lucas Di Pentima 3 months ago

Updates at fea63ac82 - branch 12414-delete-trashed-project-contents
Test run: https://ci.curoverse.com/job/developer-run-tests/673/

Ready for review.

#10 Updated by Peter Amstutz 3 months ago

This looks good. I have two small suggestions:

  1. I think you can write "klass.columns.collect{|c| c.name}" as "klass.columns.collect(&:name)"
  2. Add a couple of checks to the test "delete projects and their contents in SweepTrashedObjects" that things which shouldn't be deleted, were not deleted.

#11 Updated by Lucas Di Pentima 3 months ago

Updates at 5f463235c
Test run: https://ci.curoverse.com/job/developer-run-tests/674/

Updated test to confirm that only the expected records are being deleted.

#12 Updated by Peter Amstutz 3 months ago

Lucas Di Pentima wrote:

Updates at 5f463235c
Test run: https://ci.curoverse.com/job/developer-run-tests/674/

Updated test to confirm that only the expected records are being deleted.

This LGTM

#13 Updated by Lucas Di Pentima 3 months ago

  • Status changed from In Progress to Resolved

Also available in: Atom PDF